Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving Support for Newer FFMPEG versions #972

Merged
merged 3 commits into from
Sep 7, 2024
Merged

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Sep 6, 2024

  • Fixing Audio Channel Layout detection for WAV (and other formats) that don't include a channel layout in the header (fallback for STEREO and MONO layouts based on # of channels)
  • Fixed crashing Caption unit tests, and made them more resilient to pixel variations and font variations
  • Removed a "flush encoders" call in FFmpegWriter, which was breaking exports on newer versions of FFMPEG and breaking some hardware acceleration

…PEG no longer attempt to guess. Support for MONO and STEREO layouts added back in.
…ncoders on newer versions of FFMPEG. This would result in failed hardware acceleration and videos with no video frames.
@jonoomph jonoomph changed the title Better ffmpeg support Improving Support for Newer FFMPEG versions Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 5.26316% with 36 lines in your changes missing coverage. Please review.

Project coverage is 54.24%. Comparing base (044bb22) to head (5be0f4a).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
tests/Caption.cpp 3.03% 32 Missing ⚠️
src/FFmpegReader.cpp 20.00% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #972      +/-   ##
===========================================
- Coverage    54.27%   54.24%   -0.03%     
===========================================
  Files          182      182              
  Lines        16506    16513       +7     
===========================================
  Hits          8958     8958              
- Misses        7548     7555       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonoomph jonoomph merged commit d906231 into develop Sep 7, 2024
12 of 13 checks passed
@jonoomph jonoomph deleted the better-ffmpeg-support branch September 7, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant