Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore NULL nodes in JSON arrays (clips, effects). #942

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

jonoomph
Copy link
Member

@jonoomph jonoomph commented Oct 7, 2023

This can happen sometimes (for an unknown reason), and it currently crashes OpenShot when attempting to Export a video.

…metimes (for an unknown reason), and it currently crashes OpenShot when attempting to Export a video.
@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #942 (4af8092) into develop (95eccaf) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

@@             Coverage Diff             @@
##           develop     #942      +/-   ##
===========================================
- Coverage    54.11%   54.10%   -0.01%     
===========================================
  Files          182      182              
  Lines        16711    16717       +6     
===========================================
+ Hits          9043     9045       +2     
- Misses        7668     7672       +4     
Files Coverage Δ
src/Clip.cpp 70.17% <0.00%> (-0.17%) ⬇️
src/Timeline.cpp 55.05% <50.00%> (-0.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jonoomph jonoomph merged commit 2034f45 into develop Oct 7, 2023
7 of 15 checks passed
@jonoomph jonoomph deleted the fix-null-nodes-json branch October 7, 2023 21:18
@jonoomph
Copy link
Member Author

jonoomph commented Oct 7, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant