-
Notifications
You must be signed in to change notification settings - Fork 271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compilation fails with ffmpeg 7.0 #953
Comments
Oh I was working on this for Fedora Linux: here's my PR #954 |
channel_layout has been replaced with ch_layout Fix OpenShot#953
channel_layout has been replaced with ch_layout Fix OpenShot#953
What do you mean, my patch is on top of the develop branch, so it already includes this commit in the history? If you want the version to apply on top of the current stable version: https://src.fedoraproject.org/fork/eclipseo/rpms/libopenshot/blob/07481b00585dfa14a2a3aa8986892a9f88002338/f/0001-Add-compatibility-with-FFMPEG-7.0.patch |
I've left some feedback on #954. Hopefully we can get this merged version soon, and get it into a new production release of OpenShot. |
Yes, I mean on top of the last release. |
channel_layout has been replaced with ch_layout Fix OpenShot#953
channel_layout has been replaced with ch_layout Fix OpenShot#953
channel_layout has been replaced with ch_layout Fix OpenShot#953
channel_layout has been replaced with ch_layout Fix OpenShot#953
This fixes build, but the are many test failures when compiled against ffmpeg 7, such as
|
Is this fixed in OpenShot 3.2.0? |
If you mean libopenshot 0.3.3, no. |
Release notes: https://www.openshot.org/blog/2024/06/24/new_openshot_release_320/ Compatibility with FFMPEG 7.0 improved: build without errors, but there is an issue in the upstream bug-tracker related to the work of the software: OpenShot/libopenshot#953 (comment) PR: 278857
FreeBSD 14.0 amd64, ffmpeg 7.0.
Part of build log:
Full build log is here: https://pkg-status.freebsd.org/beefy22/data/140amd64-default-foo/2024-05-04_07h10m46s/logs/errors/py39-libopenshot-0.3.2_3.log
Maybe this can help: https://code.videolan.org/videolan/vlc/-/merge_requests/5304/diffs
AV_GET_CODEC_ATTRIBUTES(aStream, aCodecCtx)->channels
=>AV_GET_CODEC_ATTRIBUTES(aStream, aCodecCtx)->ch_layout.nb_channels
The text was updated successfully, but these errors were encountered: