editoast: fix train schedule projection cache #8954
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8954 +/- ##
=========================================
Coverage 37.20% 37.20%
Complexity 2245 2245
=========================================
Files 1260 1260
Lines 115364 115368 +4
Branches 3267 3267
=========================================
+ Hits 42920 42923 +3
- Misses 70498 70499 +1
Partials 1946 1946
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Ahhhh, the randomness of HashMap, always a little trick that comes back to bite you. Note: would a different Hasher (see https://doc.rust-lang.org/std/collections/hash_map/struct.HashMap.html#method.with_hasher) avoid this randomness, so you can keep the previous version of the code?
I can probably find another hash function to avoid randomness. However, I prefer to use indexing for readability reasons. |
The train projections retrieve in redis were associated with a random train id. Signed-off-by: Florian Amsallem <[email protected]>
flomonster
force-pushed
the
fam/fix-train-projects-cache
branch
from
024ac46
to
ed886d0
Compare
The train projections retrieve in redis were associated with a random train id.
close #8952