front: stdcm: display only CH codes associated with the selected PR #8944
+14
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #8944 +/- ##
=========================================
Coverage 37.13% 37.13%
Complexity 2211 2211
=========================================
Files 1260 1260
Lines 115076 115078 +2
Branches 3230 3230
=========================================
+ Hits 42736 42737 +1
- Misses 70407 70408 +1
Partials 1933 1933
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
reviewed
Sep 20, 2024
Comment on lines
+69
to
+70
| const isDuplicate = acc.some((option) => option.label === newObject.label); | ||
| if (!isDuplicate) acc.push(newObject); |
There was a problem hiding this comment.
I think you can try to use a set, so you don't have to bother checking if it's a duplicate or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8938