Include sd, fhd, and uhd in picon.py

[kiddac]

In a world of iptv would it be possible to amend the picon.py to include iptv references like sd, fhd, uhd, 4k

Currently SNP picons look for name and if ends with HD strips the HD

It would now be better if this code also incorporates other IPTV values like SD,4K, FHD, UHD to pick up more IPTV channels

Example new code.

if not pngname:
    name = sanitizeFilename(ServiceReference(serviceRef).getServiceName())
    name = re.sub('[^a-z0-9]', '', name.replace('&', 'and').replace('+', 'plus').replace('*', 'star').lower())
    if len(name) > 0:
        pngname = findPicon(name)
        if not pngname and len(name) > 3 and (name.endswith("fhd") or names.endswith("uhd")) :
            pngname = findPicon(name[:-3])	
        if not pngname and len(name) > 2 and (name.endswith("hd") or names.endswith("sd") or names.endswith("4k") ):
            pngname = findPicon(name[:-2])`		

[kiddac]

jbleyel on openatv has recommended a regex solution instead

if not pngname:
  name = sub("uhd$|fhd$|sd$|hd$|4k$", "", name)
  if name:
    pngname = findPicon(name)

[littlesat]

I agree this is not Pli style. Please improve with 'sub'. Can be done in a kind of oneliner

[AbuBaniaz]

The changes were added to the developer image. I have submitted a pull request to pick it into Release.
#3861

Issue can then be closed.

[WanWizard]

It might also be beneficial in that context to strip anything in square brackets from ths start.
And I have also seen "8K" (which if you're lucky is FHD), so this needs stripping too.

It would be better if IPTV tools would strip all this nonsense at the source though, instead of having to hack this into E2.

[AbuBaniaz]

But if that was done, you would not know what the quality/resolution is supposed to be.

[AbuBaniaz]

Please ignore. This is wrong.
On second thoughts and after comment by someone from another image, the wholesale trimming is not the best approach. The original suggestion where the trim is done if the full name is not found would have be better. That would have catered for channels where there are different logos for HD/SD channels.

[WanWizard]

But if that was done, you would not know what the quality/resolution is supposed to be.

I don't understand that, it is fine to strip HD and 4K, but not 8K?

And I was referring to channel name prefixes, which are currently not stripped at all, like

[BE] [8K] Play Sports 4 HVEC

which needs two prefixes stripped, and a suffix which we currently don't strip.

[AbuBaniaz]

My comment was in response to It would be better if IPTV tools would strip all this nonsense at the source though, instead of having to hack this into E2.. Not specific to 8k

My last comment is wrong, trims are done if the full name is not found

[AbuBaniaz]

I have re-opened the pull request for 9.0 branch. I would be grateful if you can consider merging it.

[littlesat]

As far I know this is included in a more smarter way.

[AbuBaniaz]

It is only in Develop image.

[pr2git]

Every IPTV providers has its own way to report there channels resolution (they are very creative on this), the implementation of the resolution strip was initially done for the satellite to have a fallback when there is no specific picon for hd (remember that at the very beginning of HD channels there was specific picon for those channels compared to SD one), so indeed the strip was done for the end of the string because it was there that it is placed on DVB transmission. And I agree that a regex would be better for perform this.

[WanWizard]

As far I know this is included in a more smarter way.

Then why is this issue still open?

[AbuBaniaz]

Because it is not in release image yet

[WanWizard]

Leaving this open doesn't change that.

If it is in develop, the issue is dealt with, and available for the wider public in the net release.

[AbuBaniaz]

I have created a pull request #4053
I hope you can merge it.