Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cinnabar analysis is outdated in the tutorial demo #268

Open
mariacm12 opened this issue Apr 16, 2024 · 1 comment
Open

Cinnabar analysis is outdated in the tutorial demo #268

mariacm12 opened this issue Apr 16, 2024 · 1 comment

Comments

@mariacm12
Copy link

I was going through the tutorial Using alchemiscale to evaluate a relative binding free energy network, and noticed that the Advanced example was assuming an older version of cinnabar.
I'm not sure if this was already in the process of being fixed, but the functions used from FEMap and cinnabar_plotting were deprecated.

The following changes fixed the issue for me:
fe = cinnabar.wrangle.FEMap('cinnabar_input.csv')
to fe = FEMap.from_csv('cinnabar_input.csv')

And converting the graph to the "legacy" format graph = fe.to_legacy_graph(), instead of graph = fe.graph

@IAlibay
Copy link
Member

IAlibay commented Apr 21, 2024

@dotsdl it sounds like we're duplicating a couple of things here that have a tutorial somewhere in the standard openfe ExampleNotebooks. To avoid things going out of date in multiple places, would it make sense to maybe redirect folks at the end of that tutorial to the standard plotting tutorial?

Maybe there's some extra linking magic that could be done here, @Yoshanuikabundi might know something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants