Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTestContextHandler does not cater for .exe assemblies #177

Open
egarson opened this issue Feb 4, 2015 · 3 comments
Open

GetTestContextHandler does not cater for .exe assemblies #177

egarson opened this issue Feb 4, 2015 · 3 comments

Comments

@egarson
Copy link

egarson commented Feb 4, 2015

Hello

The AssemblyName generated by https://github.com/OmniSharp/omnisharp-server/blob/master/OmniSharp/TestContextInformation/GetTestContextHandler.cs#L67 assumes the assembly is a .dll, and thus doesn't work for .exe.

I'm using omnisharp-emacs, and the net result of the above is that I can't run unit tests in .exe assemblies.

Is there some good reason that .dll is hardcoded?

Thank you

@nosami
Copy link
Contributor

nosami commented Feb 4, 2015

It doesn't need to be. Do you want to submit a PR?

@egarson
Copy link
Author

egarson commented Feb 5, 2015

Well in that case it's the right thing to do... I'll take a look into setting this project up, running tests and such before I verbally commit ;-)

Thank you

@nosami
Copy link
Contributor

nosami commented Feb 5, 2015

Cheers! You'll probably need to look at the project files to determine the
output path I would imagine.

On Thu, Feb 5, 2015 at 3:27 PM, Edward Garson [email protected]
wrote:

Well in that case it's the right thing to do... I'll take a look into
setting this project up, running tests and such before I verbally commit ;-)

Thank you


Reply to this email directly or view it on GitHub
#177 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants