Review RariFuseAllocator

[ghost]

Below I am giving you a link to the contract which should be reviewed including tests.

olympus-contracts/contracts/allocators/RariFuseAllocator.sol

Line 28 in 570185d

contract RariFuseAllocator is BaseAllocator {

olympus-contracts/test/allocators/RariFuseAllocator.test.ts

Line 124 in 570185d

async function setupTestingEnvironment(): Promise<void> {

olympus-contracts/scripts/typescript/deployRariFuseAllocator.ts

Line 17 in 570185d

async function main() {

[ghost]

Yes, in the future I will work on a local branch and issue this as a PR. Up until now I have been doing this on main. I will keep pushing reorganization though directly to main.

[0xLienid]

IERC20Metadata b = IERC20Metadata(address(_tokens[index]));

any reason for using IERC20Metadata vs IERC20 given you just use balanceOf and approve?
also, is there a better variable name option than "b"

[0xLienid]

if (balance > 0) { if (amounts[i] == type(uint256).max) f.redeem(f.balanceOf(address(this)));

looks like you already cache f.balanceOf(address(this)) to the balance variable, can just use here.

[ind-igo]

any reason for using IERC20Metadata vs IERC20 given you just use balanceOf and approve? also, is there a better variable name option than "b"

I think this is because he needs the decimals in the _worth function