fix: setting countryCode when updating country #3868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onearmy-community-platform
|
||||||||||||||||||||||||||||||||||||||||
| Project |
onearmy-community-platform
|
| Branch Review |
pull/3868
|
| Run status |
|
| Run duration | 15m 40s |
| Commit |
|
| Committer | Ben Furber |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
64
|
| View all changes introduced in this branch ↗︎ | |
Tests for review
src/integration/map.spec.ts • 1 failed test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [Map] > [Shows expected pins] |
Test Replay
Screenshots
Video
|
|
src/integration/howto/write.spec.ts • 1 flaky test • ci-chrome
| Test | Artifacts | |
|---|---|---|
| [How To] > [Create a how-to] > [By Authenticated] |
Test Replay
Screenshots
Video
|
|
davehakkens
added
the
Review allow-preview ✅
|
Visit the preview URL for this PR (updated for commit 2069c9e): https://onearmy-next--pr3868-fix-user-location-se-fe6p76wg.web.app (expires Sat, 26 Oct 2024 15:19:00 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 6d65e4f8fee2f6ab2da0c1c3b85b8797d66afa59 |
|
oe nice visuals flags! 💫 |
jsonDoge
reviewed
Sep 28, 2024
| @@ -218,6 +219,17 @@ export class UserStore extends ModuleStore { | |||
| ) | |||
| } | |||
|
|
|||
| if (location && location.country) { | |||
There was a problem hiding this comment.
can be shortened to location?.country :)
jsonDoge
reviewed
Sep 28, 2024
| ) | ||
| updatedUserProfile.location = { | ||
| ...location, | ||
| country: location.country, |
There was a problem hiding this comment.
If the object is being populated by ...location, the extra assignment country: location.country is redundant :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Setting your country (on the infos settings tab) doesn't set/update your flag icon on comments, etc.
What is the new behavior?
Screen.Recording.2024-09-26.at.15.45.04.mov
Also adds emojis and a little preview to show users how their location will be shown:
