Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set map pins to have profile link #3867

Merged

Conversation

benfurber
Copy link
Member

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)

What is the new behavior?

Adding back in the regular profile link for usernames on the map pin, was removed for the list cards.

Screenshot 2024-09-26 at 13 51 15

@benfurber benfurber requested a review from a team as a code owner September 26, 2024 12:52
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (1f76f8c) to head (c1724fd).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3867      +/-   ##
==========================================
- Coverage   72.54%   72.39%   -0.15%     
==========================================
  Files          43       43              
  Lines        1362     1362              
  Branches      274      274              
==========================================
- Hits          988      986       -2     
- Misses        351      352       +1     
- Partials       23       24       +1     
Flag Coverage Δ
72.39% <ø> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

cypress bot commented Sep 26, 2024

onearmy-community-platform    Run #6276

Run Properties:  status check passed Passed #6276  •  git commit c1724fd129: feat: set map pins to have profile link
Project onearmy-community-platform
Branch Review pull/3867
Run status status check passed Passed #6276
Run duration 04m 38s
Commit git commit c1724fd129: feat: set map pins to have profile link
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 65
View all changes introduced in this branch ↗︎

@benfurber benfurber merged commit c6c37cb into ONEARMY:master Sep 26, 2024
19 checks passed
@benfurber benfurber deleted the feat/new-map/set-pins-to-have-profile-link branch September 26, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant