-
-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: cy howto read flaky #3861
base: master
Are you sure you want to change the base?
Conversation
248b8ef
to
b488c13
Compare
onearmy-community-platform Run #6263
Run Properties:
|
Project |
onearmy-community-platform
|
Branch Review |
pull/3861
|
Run status |
Failed #6263
|
Run duration | 04m 26s |
Commit |
7f5c946b5a: Merge branch 'master' into 3475-cy-howto-read-flaky
|
Committer | benfurber |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
1
|
Flaky |
2
|
Pending |
0
|
Skipped |
0
|
Passing |
59
|
View all changes introduced in this branch ↗︎ |
Tests for review
src/integration/questions/discussions.spec.ts • 1 failed test • ci-chrome
Test | Artifacts | |
---|---|---|
[Questions.Discussions] > allows authenticated users to contribute to discussions |
Test Replay
Screenshots
Video
|
map.spec.ts • 1 flaky test • ci-chrome
Test | Artifacts | |
---|---|---|
[Map] > [Shows expected pins] |
Test Replay
Screenshots
Video
|
howto/read.spec.ts • 1 flaky test • ci-chrome
Test | Artifacts | |
---|---|---|
... > [See all info] |
Test Replay
Screenshots
Video
|
Before merging this PR, can you retry the e2e jobs to see if the flaky is still happening? |
we haven't had flaky tests for a while |
For the previous runs 9/15 happened this flaky as you can see here. |
Ah you are right, I was thinking about failed runs |
The test is still flaky, I will continue to investigate it. |
// Hack to get the tags store to finish populating before the expectations | ||
cy.wait(1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be very suprised if removing this helps. If anything it probably needs time added to it.
Also looks like the question discussion spec is more of a pain atm. I wonder if it's because of changes I made to the discussion data mocks recently. |
If I remember correctly, this issue has been happening for several months. I tried to investigate before. I attempted different approaches with Cypress but had no success. It might be related to how |
PR Checklist
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, the scenario [Read a How-to][By Everyone][See all info] has flaky steps when trying to assert the data on the how-to. The cause is a rerender from a cypress that loses track.
Example:
assert expected <div.howto-description-container.css-703r4> to contain product
cypress cloud with the issue
What is the new behavior?
To avoid the page being rerendered I used the aliases
Does this PR introduce a breaking change?