Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add function for pins after user updates #3852

Merged

Conversation

benfurber
Copy link
Member

@benfurber benfurber commented Sep 17, 2024

PR Checklist

PR Type

What kind of change does this PR introduce?

  • Bugfix (fixes an issue)
  • Feature (adds functionality)

What is the current behavior?

User details on map pins not updated when user updates them.

What is the new behavior?

Changes to user data now copied over to map pin creator details.

@benfurber benfurber force-pushed the feat/new-map/functions-for-user-updates branch from 2efa5d3 to 1bd1628 Compare September 19, 2024 08:07
Copy link

cypress bot commented Sep 19, 2024

onearmy-community-platform    Run #6252

Run Properties:  status check passed Passed #6252  •  git commit fc78f7d451: test: fix map db pin count
Project onearmy-community-platform
Branch Review pull/3852
Run status status check passed Passed #6252
Run duration 13m 49s
Commit git commit fc78f7d451: test: fix map db pin count
Committer Ben Furber
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 2
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 60
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 82.53968% with 11 lines in your changes missing coverage. Please review.

Project coverage is 72.45%. Comparing base (055430a) to head (fc78f7d).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
functions/src/userUpdates/updateMapPins.ts 47.05% 9 Missing ⚠️
functions/src/userUpdates/utils.ts 96.55% 1 Missing ⚠️
src/config/config.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
- Coverage   72.46%   72.45%   -0.01%     
==========================================
  Files          42       43       +1     
  Lines        1329     1358      +29     
  Branches      268      272       +4     
==========================================
+ Hits          963      984      +21     
- Misses        343      351       +8     
  Partials       23       23              
Flag Coverage Δ
72.45% <82.53%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benfurber benfurber force-pushed the feat/new-map/functions-for-user-updates branch from 91ced4a to 4d11c96 Compare September 24, 2024 12:42
@benfurber
Copy link
Member Author

Thanks for the review @jsonDoge!

@benfurber benfurber force-pushed the feat/new-map/functions-for-user-updates branch from 4d11c96 to fc78f7d Compare September 24, 2024 13:31
@benfurber benfurber merged commit fd7cb2e into ONEARMY:master Sep 24, 2024
19 checks passed
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.219.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants