Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor categories #3735

Merged
merged 2 commits into from
Jul 7, 2024
Merged

chore: refactor categories #3735

merged 2 commits into from
Jul 7, 2024

Conversation

mariojsnunes
Copy link
Collaborator

@mariojsnunes mariojsnunes commented Jul 7, 2024

PR Checklist

PR Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Developer experience (improves developer workflows for contributing to the project)

Description

Refactors Research and Howto Forms categories to use a less coupled approach.

The adopted solution is the same as implemented for Questions some time ago.
This PR aligns Howtos and Research with the new approach.

Git Issues

Working towards #3685

@mariojsnunes mariojsnunes marked this pull request as ready for review July 7, 2024 09:07
@mariojsnunes mariojsnunes requested a review from a team as a code owner July 7, 2024 09:07
Copy link

cypress bot commented Jul 7, 2024

1 flaky test on run #5933 ↗︎

0 67 1 0 Flakiness 1

Details:

chore: code cleanup
Project: onearmy-community-platform Commit: 78f1ccf933
Status: Passed Duration: 03:54 💡
Started: Jul 7, 2024 9:16 AM Ended: Jul 7, 2024 9:20 AM
Flakiness  src/integration/settings.spec.ts • 1 flaky test • ci-chrome

View Output Video

Test Artifacts
[Settings] > [Focus Community Builder] > [Edit a new profile] Test Replay Screenshots Video

Review all test suite changes for PR #3735 ↗︎

@mariojsnunes mariojsnunes merged commit 9f8f837 into master Jul 7, 2024
20 of 21 checks passed
@mariojsnunes mariojsnunes deleted the chore/refactor-categories branch July 7, 2024 09:26
@onearmy-bot
Copy link
Collaborator

🎉 This PR is included in version 1.198.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants