diff --git a/packages/cypress/src/integration/questions/read.spec.ts b/packages/cypress/src/integration/questions/read.spec.ts index 11d6dd08a6..97b66f3c64 100644 --- a/packages/cypress/src/integration/questions/read.spec.ts +++ b/packages/cypress/src/integration/questions/read.spec.ts @@ -32,6 +32,7 @@ describe('[Questions]', () => { cy.step('Can visit question') cy.visit(`/questions/${question.slug}`) + cy.title().should('eq', question.title) cy.step('All metadata visible') cy.contains(`${question.subscribers.length} following`) diff --git a/src/pages/Question/QuestionListing.tsx b/src/pages/Question/QuestionListing.tsx index 5512ffd394..5d116aa59e 100644 --- a/src/pages/Question/QuestionListing.tsx +++ b/src/pages/Question/QuestionListing.tsx @@ -28,6 +28,7 @@ export const QuestionListing = () => { const sort = searchParams.get('sort') as QuestionSortOption useEffect(() => { + document.title = 'Questions' if (!sort) { // ensure sort is set const params = new URLSearchParams(searchParams.toString()) diff --git a/src/pages/Question/QuestionPage.tsx b/src/pages/Question/QuestionPage.tsx index 754439477a..f399d896e8 100644 --- a/src/pages/Question/QuestionPage.tsx +++ b/src/pages/Question/QuestionPage.tsx @@ -15,7 +15,6 @@ import { Breadcrumbs } from 'src/pages/common/Breadcrumbs/Breadcrumbs' import { useQuestionStore } from 'src/stores/Question/question.store' import { formatImagesForGallery } from 'src/utils/formatImageListForGallery' import { buildStatisticsLabel } from 'src/utils/helpers' -import { incrementViewCount } from 'src/utils/incrementViewCount' import { Box, Button, Card, Divider, Flex, Heading, Text } from 'theme-ui' import { ContentAuthorTimestamp } from '../common/ContentAuthorTimestamp/ContentAuthorTimestamp' @@ -50,13 +49,10 @@ export const QuestionPage = () => { } store.activeQuestionItem = foundQuestion - incrementViewCount({ - document: foundQuestion, - documentType: 'question', - store, - }) + store.incrementViewCount(foundQuestion._id) setQuestion(foundQuestion) + document.title = foundQuestion.title setIsLoading(false) } @@ -164,7 +160,7 @@ export const QuestionPage = () => { { icon: 'view', label: buildStatisticsLabel({ - stat: question.total_views, + stat: question.total_views || 0, statUnit: 'view', usePlural: true, }),