Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop non-"forDonationRequest" file downloads #3858

Open
benfurber opened this issue Sep 23, 2024 · 2 comments · May be fixed by #3869
Open

Drop non-"forDonationRequest" file downloads #3858

benfurber opened this issue Sep 23, 2024 · 2 comments · May be fixed by #3869
Assignees
@mchen10
Labels
Frontend

Comments

@benfurber
Copy link
Member

Description

For research articles we setup an experiment asking users to make a small donation when downloading a file. It's gone well. So now we're ready to release the feature for all file downloads.

Build suggestion

See DownloadWithDonationAsk. Most of that can now be moved to the component library. Every use of DownloadStaticFile should now have the same implementation.
@mchen10
Copy link

mchen10 commented Sep 25, 2024

Hey! Have a PR on my local for this; would love to get the code on a working branch to get some comments and eyes.

@benfurber
Copy link
Member Author

Welcome @mchen10, have you setup a fork of the repo? Then you can submit a PR from a branch of your fork to the main repo.

@mchen10 mchen10 linked a pull request Sep 27, 2024 that will close this issue
Open
12 tasks
@davehakkens davehakkens mentioned this issue Sep 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchen10 mchen10

Labels
Frontend
Projects
Community Platform
Status: New / Under Discussion
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: elevate download with donation to component level mchen10/community-platform
2 participants
@mchen10 @benfurber