diff --git a/DESCRIPTION b/DESCRIPTION index d2c65392..aee1eb0f 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,8 +1,8 @@ Package: DataQualityDashboard Type: Package Title: Execute and View Data Quality Checks on OMOP CDM Database -Version: 2.3.0 -Date: 2023-05-21 +Version: 2.4.0 +Date: 2023-07-26 Authors@R: c( person("Katy", "Sadowski", email = "sadowski@ohdsi.org", role = c("aut", "cre")), person("Clair", "Blacketer", role = c("aut")), diff --git a/NEWS.md b/NEWS.md index 3e3e0d1b..62533c1f 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,3 +1,23 @@ +DataQualityDashboard 2.4.0 +========================== +This release includes: + +### Threshold file updates +**The following changes involve updates to the default data quality check threshold files. If you are currently using an older version of DQD and update to v2.4.0, you may see changes in your DQD results. The failure threshold changes are fixes to incorrect thresholds in the v5.4 files and thus should result in more accurate, easier to interpret results. The unit concept ID changes ensure that long-invalid concepts will no longer be accepted as plausible measurement units.** + +- The incorrect failure thresholds for `measurePersonCompleteness` and `measureValueCompleteness` were fixed in the v5.4 table & field level threshold files. This issue has existed since v5.4 support was initially added in March 2022 + - Many `measurePersonCompleteness` checks had a threshold of 0 when it should have been 95 or 100 + - Many `measureValueCompleteness` checks had a threshold of 100 when it should have been 0, and many had no threshold (defaulting to 0) when it should have been 100 + - The thresholds have now been updated to match expectations for required/non-required tables/fields +- In the v5.2, v5.3, and v5.4 table level threshold files, `measurePersonCompleteness` for the DEATH table has been toggled to `Yes`, with a threshold of 100 +- In the v5.2, v5.3, and v5.4 concept level threshold files, all references to unit concept 9117 in `plausibleUnitConceptIds` have been updated to 720870. Concept 9117 became non-standard and was replaced with concept 720870, on 28-Mar-2022 +- In the v5.2, v5.3, and v5.4 concept level threshold files, all references to unit concepts 9258 and 9259 in `plausibleUnitConceptIds` have been removed. These concepts were deprecated on 05-May-2022 + +### Bugfix +- Call to new function `convertJsonResultsFileCase` in Shiny app was appended with `DataQualityDashboard::`. This prevents potential issues related to package loading and function naming conflicts + +Some minor refactoring of testthat files and package build configuration and some minor documentation updates were also added in this release. + DataQualityDashboard 2.3.0 ========================== This release includes: diff --git a/R/convertResultsCase.R b/R/convertResultsCase.R index b6d4f357..0668b211 100644 --- a/R/convertResultsCase.R +++ b/R/convertResultsCase.R @@ -15,7 +15,7 @@ # limitations under the License. #' @title Convert JSON results file case -#' +#' #' @description Convert a DQD JSON results file between camelcase and (all-caps) snakecase. Enables viewing of pre-v.2.1.0 results files in later DQD versions, and vice versa #' #' @param jsonFilePath Path to the JSON results file to be converted diff --git a/README.md b/README.md index fdd1d407..dc3c21e8 100644 --- a/README.md +++ b/README.md @@ -88,6 +88,16 @@ User Documentation ================== Documentation can be found on the [package website](https://ohdsi.github.io/DataQualityDashboard/index.html). +PDF versions of the documentation are also available: + +* Vignette: [Add a New Data Quality Check](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/AddNewCheck.pdf) +* Vignette: [Check Status Descriptions](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/CheckStatusDefinitions.pdf) +* Vignette: [Data Quality Check Type Descriptions](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/CheckTypeDescriptions.pdf) +* Vignette: [Running the DQD on a Cohort](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/DqdForCohorts.pdf) +* Vignette: [Failure Thresholds and How to Change Them](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/Thresholds.pdf) +* Vignette: [SqlOnly Mode](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/SqlOnly.pdf) +* Package manual: [DataQualityDashboard manual](https://github.com/OHDSI/DataQualityDashboard/raw/main/inst/doc/DataQualityDashboard.pdf) + Support ======= diff --git a/docs/404.html b/docs/404.html index 7188b296..08b81bfe 100644 --- a/docs/404.html +++ b/docs/404.html @@ -32,7 +32,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/LICENSE-text.html b/docs/LICENSE-text.html index 8a7fd530..e17e3b8a 100644 --- a/docs/LICENSE-text.html +++ b/docs/LICENSE-text.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/articles/AddNewCheck.html b/docs/articles/AddNewCheck.html index 5769a243..0deb430c 100644 --- a/docs/articles/AddNewCheck.html +++ b/docs/articles/AddNewCheck.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 @@ -108,7 +108,7 @@

Add a New Data Quality Check

Don Torok

-

2023-05-21

+

2023-07-26

Source: vignettes/AddNewCheck.rmd @@ -184,15 +184,15 @@

Format the Query for th that the input parameters are correct is to use launchSqlRenderDeveloper from the SQLRender package. The package is included in the Data Quality R project.

-
-

Figure 1: launchSqlRenderDeveloper

+
+Figure 1: launchSqlRenderDeveloper
Figure 1: launchSqlRenderDeveloper

This will bring up a SqlRender window in your browser. Paste in your complete DQ query. The program will see the input parameters and allow you to define them. The rendered translation, dialect specific, is output. You can run the “Rendered Translation” on your OMOP CDM.

-
-

Figure 2: launchSqlRenderDeveloper

+
+Figure 2: launchSqlRenderDeveloper
Figure 2: launchSqlRenderDeveloper

SQL Server SQL is the lingua franca for Data Quality Dashboard queries. SQLRender will modify the query to other SQL dialects. See SQLRender diff --git a/docs/articles/CheckStatusDefinitions.html b/docs/articles/CheckStatusDefinitions.html index 5bf3ecd3..054f2894 100644 --- a/docs/articles/CheckStatusDefinitions.html +++ b/docs/articles/CheckStatusDefinitions.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0

@@ -109,7 +109,7 @@

Check Status Descriptions

Dmitry Ilyn

-

2023-05-21

+

2023-07-26

Source: vignettes/CheckStatusDefinitions.rmd diff --git a/docs/articles/CheckTypeDescriptions.html b/docs/articles/CheckTypeDescriptions.html index 81fbd664..b81d54e3 100644 --- a/docs/articles/CheckTypeDescriptions.html +++ b/docs/articles/CheckTypeDescriptions.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0
@@ -109,7 +109,7 @@

Data Quality Check Type Definitions

Clair Blacketer

-

2023-05-21

+

2023-07-26

Source: vignettes/CheckTypeDescriptions.rmd diff --git a/docs/articles/DataQualityDashboard.html b/docs/articles/DataQualityDashboard.html index 48f7a11b..9fed8026 100644 --- a/docs/articles/DataQualityDashboard.html +++ b/docs/articles/DataQualityDashboard.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 @@ -109,7 +109,7 @@

Getting Started

Clair Blacketer

-

2023-05-21

+

2023-07-26

Source: vignettes/DataQualityDashboard.rmd diff --git a/docs/articles/DqdForCohorts.html b/docs/articles/DqdForCohorts.html index beb2486f..af81a451 100644 --- a/docs/articles/DqdForCohorts.html +++ b/docs/articles/DqdForCohorts.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 @@ -109,7 +109,7 @@

Running the DQD on a Cohort

Clair Blacketer

-

2023-05-21

+

2023-07-26

Source: vignettes/DqdForCohorts.rmd diff --git a/docs/articles/SqlOnly.html b/docs/articles/SqlOnly.html index 1a3c3721..999ee7db 100644 --- a/docs/articles/SqlOnly.html +++ b/docs/articles/SqlOnly.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 @@ -109,7 +109,7 @@

SqlOnly

Maxim Moinat

-

2023-05-21

+

2023-07-26

Source: vignettes/SqlOnly.rmd @@ -126,7 +126,7 @@

2023-05-21

Description

This article describes how to use DQD to generate only the SQL that -executes all DataQualityDashoard checks, without actually executing +executes all DataQualityDashboard checks, without actually executing them. There are a few main advantages of running DQD in Sql-only mode:

-
-

Figure 1: Field Level Control File Example

+
+Figure 1: Field Level Control File Example
Figure 1: Field Level Control File Example
diff --git a/docs/articles/index.html b/docs/articles/index.html index 4a799f32..13de8fdd 100644 --- a/docs/articles/index.html +++ b/docs/articles/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/authors.html b/docs/authors.html index d98f6bef..06995b97 100644 --- a/docs/authors.html +++ b/docs/authors.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/index.html b/docs/index.html index 2dd5cdbf..1f06facc 100644 --- a/docs/index.html +++ b/docs/index.html @@ -33,7 +33,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 @@ -240,6 +240,23 @@

InstallationUser Documentation

Documentation can be found on the package website.

+

PDF versions of the documentation are also available:

+

Support diff --git a/docs/news/index.html b/docs/news/index.html index aa51707f..4221e1c5 100644 --- a/docs/news/index.html +++ b/docs/news/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0

@@ -84,13 +84,34 @@

Changelog

Source: NEWS.md +
+

DataQualityDashboard 2.4.0

+

This release includes:

+
+

Threshold file updates

+

The following changes involve updates to the default data quality check threshold files. If you are currently using an older version of DQD and update to v2.4.0, you may see changes in your DQD results. The failure threshold changes are fixes to incorrect thresholds in the v5.4 files and thus should result in more accurate, easier to interpret results. The unit concept ID changes ensure that long-invalid concepts will no longer be accepted as plausible measurement units.

+
+
+

Bugfix

+

Some minor refactoring of testthat files and package build configuration and some minor documentation updates were also added in this release.

+
+

DataQualityDashboard 2.3.0

This release includes:

New features

@@ -170,6 +191,10 @@

outputFolder input parameter

+

Removal of measurement plausibility checks

+
+

Integrated testing was also added and the package was refactored on the backend

diff --git a/docs/pkgdown.yml b/docs/pkgdown.yml index 7982666c..f8935271 100644 --- a/docs/pkgdown.yml +++ b/docs/pkgdown.yml @@ -1,4 +1,4 @@ -pandoc: 2.19.2 +pandoc: 3.1.1 pkgdown: 2.0.7 pkgdown_sha: ~ articles: @@ -9,5 +9,5 @@ articles: DqdForCohorts: DqdForCohorts.html SqlOnly: SqlOnly.html Thresholds: Thresholds.html -last_built: 2023-05-21T18:40Z +last_built: 2023-07-26T22:27Z diff --git a/docs/pull_request_template.html b/docs/pull_request_template.html index 73f4a6b2..3b09607c 100644 --- a/docs/pull_request_template.html +++ b/docs/pull_request_template.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/convertJsonResultsFileCase.html b/docs/reference/convertJsonResultsFileCase.html index 9cd0e651..f500b713 100644 --- a/docs/reference/convertJsonResultsFileCase.html +++ b/docs/reference/convertJsonResultsFileCase.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-evaluateThresholds.html b/docs/reference/dot-evaluateThresholds.html index f2b5a00b..a2a4a2aa 100644 --- a/docs/reference/dot-evaluateThresholds.html +++ b/docs/reference/dot-evaluateThresholds.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-getCheckId.html b/docs/reference/dot-getCheckId.html index 062d8cc0..05ebe3d2 100644 --- a/docs/reference/dot-getCheckId.html +++ b/docs/reference/dot-getCheckId.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-processCheck.html b/docs/reference/dot-processCheck.html index 10fcaa63..1512a950 100644 --- a/docs/reference/dot-processCheck.html +++ b/docs/reference/dot-processCheck.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-recordResult.html b/docs/reference/dot-recordResult.html index ca5dd5c1..05f65915 100644 --- a/docs/reference/dot-recordResult.html +++ b/docs/reference/dot-recordResult.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-runCheck.html b/docs/reference/dot-runCheck.html index 9f3d02cc..a0fe4284 100644 --- a/docs/reference/dot-runCheck.html +++ b/docs/reference/dot-runCheck.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-summarizeResults.html b/docs/reference/dot-summarizeResults.html index 1cb3b6a9..c446b8a6 100644 --- a/docs/reference/dot-summarizeResults.html +++ b/docs/reference/dot-summarizeResults.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-writeResultsToCsv.html b/docs/reference/dot-writeResultsToCsv.html index 7ea3836b..f7eb0746 100644 --- a/docs/reference/dot-writeResultsToCsv.html +++ b/docs/reference/dot-writeResultsToCsv.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-writeResultsToJson.html b/docs/reference/dot-writeResultsToJson.html index a0f1bd76..7f72e2ce 100644 --- a/docs/reference/dot-writeResultsToJson.html +++ b/docs/reference/dot-writeResultsToJson.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/dot-writeResultsToTable.html b/docs/reference/dot-writeResultsToTable.html index 1944a661..e9b772dc 100644 --- a/docs/reference/dot-writeResultsToTable.html +++ b/docs/reference/dot-writeResultsToTable.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/executeDqChecks.html b/docs/reference/executeDqChecks.html index d06ea101..b0aa1a39 100644 --- a/docs/reference/executeDqChecks.html +++ b/docs/reference/executeDqChecks.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/index.html b/docs/reference/index.html index f8d63ac3..0c6d792b 100644 --- a/docs/reference/index.html +++ b/docs/reference/index.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/listDqChecks.html b/docs/reference/listDqChecks.html index 9aa42f06..fa949f69 100644 --- a/docs/reference/listDqChecks.html +++ b/docs/reference/listDqChecks.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/reEvaluateThresholds.html b/docs/reference/reEvaluateThresholds.html index b15a7fcb..c23b381b 100644 --- a/docs/reference/reEvaluateThresholds.html +++ b/docs/reference/reEvaluateThresholds.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/viewDqDashboard.html b/docs/reference/viewDqDashboard.html index 7ee8d4be..b8e38e32 100644 --- a/docs/reference/viewDqDashboard.html +++ b/docs/reference/viewDqDashboard.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/writeJsonResultsToCsv.html b/docs/reference/writeJsonResultsToCsv.html index cea6f937..904f171f 100644 --- a/docs/reference/writeJsonResultsToCsv.html +++ b/docs/reference/writeJsonResultsToCsv.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/docs/reference/writeJsonResultsToTable.html b/docs/reference/writeJsonResultsToTable.html index 55e340e7..8f1cff77 100644 --- a/docs/reference/writeJsonResultsToTable.html +++ b/docs/reference/writeJsonResultsToTable.html @@ -17,7 +17,7 @@ DataQualityDashboard - 2.3.0 + 2.4.0 diff --git a/extras/DataQualityDashboard.pdf b/extras/DataQualityDashboard.pdf index 34e136a4..71a5842d 100644 Binary files a/extras/DataQualityDashboard.pdf and b/extras/DataQualityDashboard.pdf differ diff --git a/inst/doc/AddNewCheck.pdf b/inst/doc/AddNewCheck.pdf index 87d2bb58..50f6d97c 100644 Binary files a/inst/doc/AddNewCheck.pdf and b/inst/doc/AddNewCheck.pdf differ diff --git a/inst/doc/CheckStatusDefinitions.pdf b/inst/doc/CheckStatusDefinitions.pdf index ff2740f1..0b2209f7 100644 Binary files a/inst/doc/CheckStatusDefinitions.pdf and b/inst/doc/CheckStatusDefinitions.pdf differ diff --git a/inst/doc/CheckTypeDescriptions.pdf b/inst/doc/CheckTypeDescriptions.pdf index 1c0399d6..6fddddff 100644 Binary files a/inst/doc/CheckTypeDescriptions.pdf and b/inst/doc/CheckTypeDescriptions.pdf differ diff --git a/inst/doc/DataQualityDashboard.pdf b/inst/doc/DataQualityDashboard.pdf index e35750d9..89042448 100644 Binary files a/inst/doc/DataQualityDashboard.pdf and b/inst/doc/DataQualityDashboard.pdf differ diff --git a/inst/doc/DqdForCohorts.pdf b/inst/doc/DqdForCohorts.pdf index 306e46d5..d692f689 100644 Binary files a/inst/doc/DqdForCohorts.pdf and b/inst/doc/DqdForCohorts.pdf differ diff --git a/inst/doc/SqlOnly.pdf b/inst/doc/SqlOnly.pdf index cdeafd18..4f9f5637 100644 Binary files a/inst/doc/SqlOnly.pdf and b/inst/doc/SqlOnly.pdf differ diff --git a/inst/doc/Thresholds.pdf b/inst/doc/Thresholds.pdf index 0aa1e7f2..6775e554 100644 Binary files a/inst/doc/Thresholds.pdf and b/inst/doc/Thresholds.pdf differ diff --git a/tests/testthat/test-executeDqChecks.R b/tests/testthat/test-executeDqChecks.R index a5027835..e4183cbd 100644 --- a/tests/testthat/test-executeDqChecks.R +++ b/tests/testthat/test-executeDqChecks.R @@ -227,7 +227,7 @@ test_that("Execute DQ checks using sqlOnly=TRUE and sqlOnlyUnionCount=4 and sqlO expect_true("ddlDqdResults.sql" %in% list.files(outputFolder)) dqdSqlFile <- "TABLE_measurePersonCompleteness.sql" expect_true(dqdSqlFile %in% list.files(outputFolder)) - + dqdSqlFilePath <- file.path(outputFolder, dqdSqlFile) expect_snapshot(cat(SqlRender::readSql(dqdSqlFilePath))) }) @@ -256,7 +256,7 @@ test_that("Execute DQ checks using sqlOnly=TRUE and sqlOnlyUnionCount=1 and sqlO expect_true("ddlDqdResults.sql" %in% list.files(outputFolder)) dqdSqlFile <- "TABLE_measurePersonCompleteness.sql" expect_true(dqdSqlFile %in% list.files(outputFolder)) - + dqdSqlFilePath <- file.path(outputFolder, dqdSqlFile) expect_snapshot(cat(SqlRender::readSql(dqdSqlFilePath))) }) @@ -285,7 +285,7 @@ test_that("Execute DQ checks using sqlOnly=TRUE and sqlOnlyUnionCount=1 and sqlO expect_true("ddlDqdResults.sql" %in% list.files(outputFolder)) dqdSqlFile <- "measurePersonCompleteness.sql" expect_true(dqdSqlFile %in% list.files(outputFolder)) - + dqdSqlFilePath <- file.path(outputFolder, dqdSqlFile) expect_snapshot(cat(SqlRender::readSql(dqdSqlFilePath))) }) @@ -320,9 +320,9 @@ test_that("Incremental insert SQL is valid.", { on.exit(DatabaseConnector::disconnect(connection), add = TRUE) DatabaseConnector::executeSql(connection = connection, sql = ddlSql) DatabaseConnector::executeSql(connection = connection, sql = checkSql) - + checkResults <- DatabaseConnector::renderTranslateQuerySql(connection, "SELECT * FROM @database_schema.dqd_results;", database_schema = resultsDatabaseSchemaEunomia) expect_equal(nrow(checkResults), 16) - + DatabaseConnector::renderTranslateExecuteSql(connection, "DROP TABLE @database_schema.dqd_results;", database_schema = resultsDatabaseSchemaEunomia) }) diff --git a/tests/testthat/test-listChecks.R b/tests/testthat/test-listChecks.R index 777127e5..8bfe043d 100644 --- a/tests/testthat/test-listChecks.R +++ b/tests/testthat/test-listChecks.R @@ -4,4 +4,4 @@ test_that("listDqChecks works", { checks <- listDqChecks() expect_equal(length(checks), 4) expect_true(all(sapply(checks, is.data.frame))) -}) \ No newline at end of file +}) diff --git a/tests/testthat/test-reEvaluateThresholds.R b/tests/testthat/test-reEvaluateThresholds.R index 0ae9fec9..eb56bdd5 100644 --- a/tests/testthat/test-reEvaluateThresholds.R +++ b/tests/testthat/test-reEvaluateThresholds.R @@ -3,7 +3,7 @@ library(testthat) test_that("Execute reEvaluateThresholds on Synthea/Eunomia", { outputFolder <- tempfile("dqd_") on.exit(unlink(outputFolder, recursive = TRUE)) - + expect_warning( results <- executeDqChecks( connectionDetails = connectionDetailsEunomia, @@ -16,9 +16,9 @@ test_that("Execute reEvaluateThresholds on Synthea/Eunomia", { ), regexp = "^Missing check names.*" ) - + jsonPath <- list.files(outputFolder, ".json", full.names = TRUE) - + results2 <- reEvaluateThresholds( jsonFilePath = jsonPath, outputFolder = outputFolder, @@ -26,4 +26,4 @@ test_that("Execute reEvaluateThresholds on Synthea/Eunomia", { ) expect_type(results2, "list") -}) \ No newline at end of file +}) diff --git a/tests/testthat/test-writeJsonResultsTo.R b/tests/testthat/test-writeJsonResultsTo.R index b51b654e..7aff258f 100644 --- a/tests/testthat/test-writeJsonResultsTo.R +++ b/tests/testthat/test-writeJsonResultsTo.R @@ -3,7 +3,7 @@ library(testthat) test_that("Write JSON results", { outputFolder <- tempfile("dqd_") on.exit(unlink(outputFolder, recursive = TRUE)) - + expect_warning( results <- executeDqChecks( connectionDetails = connectionDetailsEunomia, @@ -16,7 +16,7 @@ test_that("Write JSON results", { ), regexp = "^Missing check names.*" ) - + jsonPath <- list.files(outputFolder, ".json", full.names = TRUE) csvPath <- file.path(outputFolder, "results.csv") writeJsonResultsToCsv( @@ -24,7 +24,7 @@ test_that("Write JSON results", { csvPath = csvPath ) expect_true(file.exists(csvPath)) - + DataQualityDashboard::writeJsonResultsToTable( connectionDetails = connectionDetailsEunomia, resultsDatabaseSchema = resultsDatabaseSchemaEunomia, @@ -36,4 +36,4 @@ test_that("Write JSON results", { tableNames <- DatabaseConnector::getTableNames(connection = connection, databaseSchema = resultsDatabaseSchemaEunomia) expect_true("dqd_results" %in% tolower(tableNames)) DatabaseConnector::renderTranslateExecuteSql(connection, "DROP TABLE @database_schema.dqd_results;", database_schema = resultsDatabaseSchemaEunomia) -}) \ No newline at end of file +})