Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add msbuild extension point after Directory.Packages.props is imported #13743

Open
ViktorHofer opened this issue Aug 27, 2024 · 1 comment · May be fixed by NuGet/NuGet.Client#5996
Open

Add msbuild extension point after Directory.Packages.props is imported #13743

ViktorHofer opened this issue Aug 27, 2024 · 1 comment · May be fixed by NuGet/NuGet.Client#5996
Labels
missing-required-type The required type label is missing.

Comments

@ViktorHofer
Copy link

Define an msbuild extension point to be able to import msbuild logic directly after the Directory.Packages.props file gets imported.

This mimics the extension point that already exists for Directory.Packages.props: https://github.com/dotnet/msbuild/blob/07a6d0d9cd3515987587b34dd8171c5c7372dcd9/src/Tasks/Microsoft.Common.props#L36

This is useful as source-build updates the Version metadata on the PackageVersion items to lift dependencies to a live built version.
@ViktorHofer ViktorHofer linked a pull request Aug 27, 2024 that will close this issue
Open
3 tasks
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Issue is missing Type label, remember to add a Type label

@dotnet-policy-service dotnet-policy-service bot added the missing-required-type The required type label is missing. label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing-required-type The required type label is missing.
Projects
None yet
Milestone
No milestone
1 participant
@ViktorHofer