Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-add --prefer-offline flag to workflows #4823

Closed
fvictorio opened this issue Feb 5, 2024 · 1 comment
Closed

Re-add --prefer-offline flag to workflows #4823

fvictorio opened this issue Feb 5, 2024 · 1 comment
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users

Comments

@fvictorio
Copy link
Member

This commit in this PR removed the --prefer-offline flag from all workflows. The reason for this is that, for some reason, the node_modules directory stopped being created under the hardhat-verify package when that flag is used, and this causes the rest of the workflows to fail.

This seems like a pnpm bug to me, but maybe we have a problem in our repo. In any case, we should try re-adding it at some point.

Checking if this was fixed in the latest version of pnpm should be easy:

  1. Clone the repo
  2. Run pnpm install --frozen-lockfile --prefer-offline && pnpm build

If the build fails, then the problem is still there.
@fvictorio fvictorio added the type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users label Feb 5, 2024
@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 5, 2024
@fvictorio
Copy link
Member Author

Guess who opened an issue about undoing a workaround before checking that the workaround actually, you know, worked.

Anyway: I ended up deleting the pnpm-lock.yaml file and re-creating it and that did work.

@fvictorio fvictorio closed this as not planned Won't fix, can't repro, duplicate, stale Feb 5, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status:ready This issue is ready to be worked on type:chore A task related to code quality, tooling, CI, or anything that doesn't directly impact the end users
Projects
Hardhat
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fvictorio