From 2b3ea88ba3b19d435d0bcacc757d5378f431d430 Mon Sep 17 00:00:00 2001 From: Brian Harrington Date: Mon, 18 Jan 2016 08:11:49 -0800 Subject: [PATCH] indicate type as prefix on idx value Timers are mapped to nanoseconds before computing the bucket. This allows better precision without needing to support floating point. For display it is often preferred to use base units, like seconds. In any case, it is useful to distinguish whether the value was reported for a timer or a distribution summary. The index value stored for the `percentile` key is now prefixed with a `T` for timers and `D` for distribution summaries. --- .../spectator/api/histogram/PercentileDistributionSummary.java | 2 +- .../com/netflix/spectator/api/histogram/PercentileTimer.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileDistributionSummary.java b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileDistributionSummary.java index e7b030805..f0f5ba14e 100644 --- a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileDistributionSummary.java +++ b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileDistributionSummary.java @@ -53,7 +53,7 @@ public static PercentileDistributionSummary get(Registry registry, Id id) { this.summary = registry.distributionSummary(id); this.counters = new Counter[PercentileBuckets.length()]; for (int i = 0; i < counters.length; ++i) { - Id counterId = id.withTag("percentile", String.format("%04X", i)); + Id counterId = id.withTag("percentile", String.format("D%04X", i)); counters[i] = registry.counter(counterId); } } diff --git a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java index e0a62c7e0..fbf417424 100644 --- a/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java +++ b/spectator-api/src/main/java/com/netflix/spectator/api/histogram/PercentileTimer.java @@ -58,7 +58,7 @@ public static PercentileTimer get(Registry registry, Id id) { this.timer = registry.timer(id); this.counters = new Counter[PercentileBuckets.length()]; for (int i = 0; i < counters.length; ++i) { - Id counterId = id.withTag("percentile", String.format("%04X", i)); + Id counterId = id.withTag("percentile", String.format("T%04X", i)); counters[i] = registry.counter(counterId); } }