Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[auth][android] signOut return undefined #174

Open
kefahB opened this issue Jan 21, 2023 · 0 comments
Open

[auth][android] signOut return undefined #174

kefahB opened this issue Jan 21, 2023 · 0 comments

Comments

@kefahB
Copy link
Contributor

kefahB commented Jan 21, 2023 •
edited
Loading

Hello @NathanWalker and @triniwiz

The signOut on android return undefined instead of boolean! the workaround is fixed by adding async await but this will force us to change the return type to Promise! and if we did we should doing same for IOS as well.

What do you think ?

firebase/packages/firebase-auth/index.android.ts

Line 1398 in 8897266

return this.native?.signOut?.();

@kefahB kefahB mentioned this issue Jan 21, 2023
Merged
triniwiz pushed a commit that referenced this issue Mar 23, 2023
@kefahB
[auth][android] resolve signOut return undefined #174 (#175)
ab61707 
* Update README.md

* Update index.d.ts

* Update index.android.ts

* Update index.ios.ts

* [Android] Fixe signOut return

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kefahB