Dark Mode

[sagar-barapatre]

It's not required now but in future we can implement the feature of dark mode on our website. So that user to toggle the button to switch to different themes.

[Namanl2001]

Thanks! again @sagar-barapatre for opening this issue.
In general, I see a dark theme as a nice-to-have, but we have to weigh the costs. My main reservations are:

• It will be more work to implement than it may seem at first. CSS styles are in inline styles in the JSX.
• We also need to make sure that everything still looks ok in both light and dark modes after any new addition or change.
• visual testing is more difficult.

None of that is a major problem, if someone wants to contribute to this, I'm happy to help.

[sagar-barapatre]

Yeah! I think it's a big task, so let this issue be open. This issue will maybe require a team of 3-4 people who can review over the feature.

[thaditi]

Hey @Namanl2001 and @sagar-barapatre. I would like to work on this issue as part of GSSOC'21.

[khareyash05]

Hey @Namanl2001 and @sagar-barapatre .I would like to work on this issue.If no one else is assigned.I will work on this issue as a part of GSSOC'21

[sagar-barapatre]

Actually this issue might require 2-3 people for testing this feature. So shall we together work on this issue ?
What say @Namanl2001 @thaditi @khareyash05 ??

[khareyash05]

@sagar-barapatre I would love to

[thaditi]

@sagar-barapatre Sure.

[Namanl2001]

Great! now as we have a team of three I think you all can start discussing your ideas and approach with each other. Here on the issue or in the discussions https://github.com/Namanl2001/MERN-Gurujii-dev/discussions.

Hopefully we would have a separate discord channel for our project and a project mentor with us soon, provided by the GSSoC'21 team.
Thank you @thaditi @khareyash05 @sagar-barapatre for taking up this issue.

All the best!!

[sagar-barapatre]

Great! now as we have a team of three I think you all can start discussing your ideas and approach with each other. Here on the issue or in the discussions https://github.com/Namanl2001/MERN-Gurujii-dev/discussions.

Hopefully we would have a separate discord channel for our project and a project mentor with us soon, provided by the GSSoC'21 team.
Thank you @thaditi @khareyash05 @sagar-barapatre for taking up this issue.

All the best!!

P.S. - I m already a mentor

[khareyash05]

I have added a dark mode toggle. on the bottom right corner.Its a perfect working one and we can also isolate those elements whose styling is not to be changed....Also it remembers the mode(dark/light) when the last time u opened it.
Suggest me with some changes

[Namanl2001]

@khareyash05 open a PR then it would be easy to review it.

[khareyash05]

I have opened a PR kindly review the same

[sagar-barapatre]

Can you place the toggle button just besides the Google signin button, coz generally dark mode buttons are place at top right corners in almost every website.
This is just a suggestion.

[ritik307]

@sagar-barapatre @Namanl2001 @khareyash05 is anyone working on this issue. If not then can you plz assign this issue to me?

[khareyash05]

@ritik307 I am working on the issue

[Jassi10000-zz]

@Namanl2001 Is the issue still open , being a GSSOC'21 participant I want to try my hands out on this issue

[sagar-barapatre]

@Jassi10000 PR has already been made. So you can suggest some changes which you would like to if you want.

[Jassi10000-zz]

Sure

[khareyash05]

@sagar-barapatre @Namanl2001 I am getting this error Kindly help me
I have not changed a thing in the file mentioned in the error

[sagar-barapatre]

set { hidden : false }
The error gets removed

[subhangi2731]

@Namanl2001 @sagar-barapatre please assign me this I want to work on this

[sagar-barapatre]

Okay assigned.