Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub actions #12

Merged
merged 2 commits into from
Apr 15, 2024
Merged

Add GitHub actions #12

merged 2 commits into from
Apr 15, 2024

Conversation

ArangoGutierrez
Copy link
Collaborator

No description provided.

@ArangoGutierrez ArangoGutierrez self-assigned this Mar 13, 2024
@ArangoGutierrez ArangoGutierrez force-pushed the githubactions branch 2 times, most recently from 4b76859 to d2bc105 Compare March 13, 2024 12:52
elezar
elezar requested changes Mar 13, 2024
View reviewed changes
Copy link
Member

@elezar elezar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make golangci-lint optionional (or skipped) in this PR and then address the issues in a follow-up.

Some changes required regardless.

.golangci.yml Outdated Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
pkg/types/vgpu_config.go Show resolved Hide resolved
.golangci.yml Outdated Show resolved Hide resolved
api/spec/v1/helpers.go Outdated Show resolved Hide resolved
cmd/nvidia-vgpu-dm/apply/apply.go Outdated Show resolved Hide resolved
cmd/nvidia-vgpu-dm/assert/assert.go Outdated Show resolved Hide resolved
deployments/container/main.go Outdated Show resolved Hide resolved
tariq1890
tariq1890 reviewed Mar 13, 2024
View reviewed changes
.github/workflows/images.yml Show resolved Hide resolved
.github/workflows/images.yml Show resolved Hide resolved
.github/workflows/images.yml Show resolved Hide resolved
@ArangoGutierrez
Copy link
Collaborator Author

@tariq1890 all your recommendations sound good, but the idea is to have all repos with a similar structure.
I think your recommendations are good for a follow-up tasks to implement your changes to ALL repos. But in this initial phase I don't want to deviate from the baseline, Let's have all repos in sync before optimizations

@ArangoGutierrez ArangoGutierrez force-pushed the githubactions branch 3 times, most recently from 45ce6f5 to c642cad Compare March 15, 2024 14:17
@ArangoGutierrez
Copy link
Collaborator Author

Hey @tariq1890 can we move forward with this PR?

@ArangoGutierrez
Copy link
Collaborator Author

@elezar PTAL

@ArangoGutierrez
Copy link
Collaborator Author

@cdesiniotis PTAL

@cdesiniotis
Copy link
Contributor

@ArangoGutierrez this needs a rebase

@ArangoGutierrez
Add GitHub actions
50029af 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Add golanci-lint config file and address lints
1342444 
Signed-off-by: Carlos Eduardo Arango Gutierrez <[email protected]>
@ArangoGutierrez
Copy link
Collaborator Author

@ArangoGutierrez this needs a rebase

done

@ArangoGutierrez ArangoGutierrez merged commit 5a68d55 into NVIDIA:main Apr 15, 2024
4 checks passed
@ArangoGutierrez ArangoGutierrez deleted the githubactions branch April 15, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tariq1890 tariq1890 tariq1890 approved these changes

@cdesiniotis cdesiniotis cdesiniotis approved these changes

@elezar elezar Awaiting requested review from elezar

Assignees

@ArangoGutierrez ArangoGutierrez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ArangoGutierrez @cdesiniotis @elezar @tariq1890