Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OLM bundle to use staging images built from release branch #908

Open
wants to merge 1 commit into
base: release-24.6
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ metadata:
capabilities: Deep Insights
categories: AI/Machine Learning, OpenShift Optional
certified: "true"
containerImage: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:main-latest-ubi8
containerImage: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdesiniotis the CI is failing with:

level=error msg="failed to validate images: failed to validate image gpu-operator-image: failed to get image manifest: failed to get manifest registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8: request failed: not found [http 404]: {\"errors\":[{\"code\":\"MANIFEST_UNKNOWN\",\"message\":\"manifest unknown\",\"detail\":{\"Tag\":\"release-24.6-latest-ubi8\"}}]}\n"

Are these images used, or should we be using the ghcr.io images?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense to publish latest images on release branches to ghcr.io. The image in gitlab exists though: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8

createdAt: "Thu Jul 27 13:57:56 PDT 2023"
description: Automate the management and monitoring of NVIDIA GPUs.
provider: NVIDIA
Expand All @@ -201,7 +201,7 @@ spec:
apiservicedefinitions: {}
relatedImages:
- name: gpu-operator-image
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:main-latest-ubi8
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8
- name: dcgm-exporter-image
image: nvcr.io/nvidia/k8s/dcgm-exporter@sha256:21f4c8b88716e8e6f732f9fb4c2efaef937c227491a8631c5e55036f80f39a4d
- name: dcgm-image
Expand All @@ -223,7 +223,7 @@ spec:
- name: init-container-image
image: nvcr.io/nvidia/cuda@sha256:b0b6c9286f20432ba9becb711aff2d1c1bd56e47b33e6d1cab04aba926c067fe
- name: gpu-operator-validator-image
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-validator:main-latest-ubi8
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-validator:release-24.6-latest-ubi8
- name: k8s-driver-manager-image
image: nvcr.io/nvidia/cloud-native/k8s-driver-manager@sha256:740abc3ff657545c10effd5354f09af525200ed9a1b7623f0c2e8c7bd9e4a4e2
- name: vfio-manager-image
Expand Down Expand Up @@ -818,7 +818,7 @@ spec:
- --leader-elect
- --leader-lease-renew-deadline
- "60s"
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:main-latest-ubi8
image: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8
command:
- gpu-operator
livenessProbe:
Expand Down Expand Up @@ -856,7 +856,7 @@ spec:
fieldRef:
fieldPath: metadata.namespace
- name: "VALIDATOR_IMAGE"
value: "registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-validator:main-latest-ubi8"
value: "registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator-validator:release-24.6-latest-ubi8"
- name: "GFD_IMAGE"
value: "nvcr.io/nvidia/k8s-device-plugin@sha256:7ad2c9f71fe06f9f7745ac8635f46740fbdff4f11edd468addfab81afcdfa534"
- name: "CONTAINER_TOOLKIT_IMAGE"
Expand Down
Loading