Update OLM bundle to use staging images built from release branch #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Desiniotis <[email protected]>
cdesiniotis
requested review from
ArangoGutierrez,
elezar,
shivamerla and
tariq1890
as code owners
elezar
previously approved these changes
Aug 14, 2024
elezar
reviewed
Aug 14, 2024
| @@ -189,7 +189,7 @@ metadata: | |||
| capabilities: Deep Insights | |||
| categories: AI/Machine Learning, OpenShift Optional | |||
| certified: "true" | |||
| containerImage: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:main-latest-ubi8 | |||
| containerImage: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8 | |||
There was a problem hiding this comment.
@cdesiniotis the CI is failing with:
level=error msg="failed to validate images: failed to validate image gpu-operator-image: failed to get image manifest: failed to get manifest registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8: request failed: not found [http 404]: {\"errors\":[{\"code\":\"MANIFEST_UNKNOWN\",\"message\":\"manifest unknown\",\"detail\":{\"Tag\":\"release-24.6-latest-ubi8\"}}]}\n"
Are these images used, or should we be using the ghcr.io images?
There was a problem hiding this comment.
makes sense to publish latest images on release branches to ghcr.io. The image in gitlab exists though: registry.gitlab.com/nvidia/kubernetes/gpu-operator/staging/gpu-operator:release-24.6-latest-ubi8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.