Add Env valueFrom function #743
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change Env field in NvidiaDriver spec from []EnvVar to []corev1.EnvVar to ensure consistency with Kubernetes core API types. - Regenerate deepcopy code to reflect the changes in the API type. This change improves integration and compatibility with Kubernetes environments and tooling.
…tests
Updated internal/state/driver_test.go and controllers/object_controls_test.go to use corev1.EnvVar instead of nvidiav1alpha1.EnvVar for environment variables.
- Changed Env: []nvidiav1alpha1.EnvVar{...} to Env: []corev1.EnvVar{...}.
This refactoring aligns with the use of standard corev1.EnvVar across the project.
mayooot
requested review from
ArangoGutierrez,
cdesiniotis,
elezar,
shivamerla and
tariq1890
as code owners
mayooot
force-pushed
the
feat/support-envfrom
branch
from
406fdaa
to
6021879
Compare
mayooot
force-pushed
the
feat/support-envfrom
branch
from
6021879
to
952510a
Compare
|
@mayooot one of the primary reason was that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this pr is to provide
valueFromfunctionality for CRD, like: environment-variable-expose-pod-informationThe main change is to the CRD definition under
api/nvidia/xxx_types.go, from the custom structEnvVartocorev1.EnvVar.Why did you add this feature?
We modified the k8s-device-plugin code to support multiple gpu spec via valueFrom. And for the gpu-operator modification, we've tested it ourselves to make sure it's not a problem.
The main reason for this is that we believe that the EnvVar struct should be consistent with the K8s API instead of using a custom struct.