Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definitions from header file #2028

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ParamThakkar123
Copy link

Description

Addresses issue #1911

Copy link

copy-pr-bot bot commented Jul 30, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

github-actions bot commented Jul 30, 2024

CLA Assistant Lite bot All Contributors have signed the CLA.

@ParamThakkar123
Copy link
Author

I have read the Contributor License Agreement and I hereby accept the Terms.

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Jul 30, 2024

/ok to test

Command Bot: Processing...

@khalatepradnya
Copy link
Collaborator

khalatepradnya commented Jul 31, 2024

/ok to test

Command Bot: Processing...

@ParamThakkar123
Copy link
Author

image

@khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

@ParamThakkar123
Copy link
Author

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

@khalatepradnya
Copy link
Collaborator

image

@khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

Is this the error message you get when building your branch locally?
(I see that CI is failing with error: 'annotate' attribute requires a string)

@khalatepradnya
Copy link
Collaborator

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

I don't see any changes to cmake in this PR. I suspect the build is not able to locate the new file, can you check target_include_directories?

@ParamThakkar123
Copy link
Author

@khalatepradnya can you please explain me what's the problem here ?? So I can try to fix this

I don't see any changes to cmake in this PR. I suspect the build is not able to locate the new file, can you check target_include_directories?

Ok I will try this

@ParamThakkar123
Copy link
Author

@khalatepradnya I didn't find any issues with target_include_directories

@schweitzpgi
Copy link
Collaborator

image
@khalatepradnya this doesn't give and error in other files but this some thing gives an error in qubit_qis.h . Why is this happening ?

Is this the error message you get when building your branch locally? (I see that CI is failing with error: 'annotate' attribute requires a string)

Unfortunately, __attribute__((annotate(thing))) isn't very smart and strictly requires a C style string literal to appear inline for thing. Sad, but true. So we can't use a symbolic for thing in these cases.

@schweitzpgi
Copy link
Collaborator

@ParamThakkar123 do you want to take another stab at this one?

@ParamThakkar123
Copy link
Author

@ParamThakkar123 do you want to take another stab at this one?

Yeah would like to work on this. But would need some help from your side not to solve this issue but to get a better understanding of this codebase.

@khalatepradnya
Copy link
Collaborator

@ParamThakkar123 do you want to take another stab at this one?

Yeah would like to work on this. But would need some help from your side not to solve this issue but to get a better understanding of this codebase.

Hi! If you want to continue investigating this build failure, I recommend first aligning with main and re-running the build. If you happen to have error message from your local build environment, please share it so we can debug further. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants