FuseWithConstantArray on ExtractValueOp always returns success() #2196
Assignees
Labels
bug
Something isn't working
Comments
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this issue
Sep 6, 2024
Canonicalization patterns should return failure if they don't modify the IR.
schweitzpgi
added a commit
to schweitzpgi/cuda-quantum
that referenced
this issue
Sep 6, 2024
Canonicalization patterns should return failure if they don't modify the IR.
schweitzpgi
added a commit
that referenced
this issue
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
FuseWithConstantArray::matchAndRewriteis returning success even if no canonicalization is applied. I'm not 100% sure, but I think that final return statement should be areturn failure();. I noticed this when I tried to add more canonicalization patterns forExtractValueOpand they would not run, and my guess was that it was because the first pass,FuseWithConstantArraywas always returning success.The text was updated successfully, but these errors were encountered: