suggestion for issue 676 #790
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Joe. Is this sort of thing OK for #676 ?
(jest tests pass)
I'd want deterministic logic that can override defaults.
Scenarios (all in the same timeline)
"headline": "Report: turns out Einstein was wrong"
could have a hash of "#report-turns-out-einstein-was-wrong"
"headline": "Opinion: Soccer matches ending in nil-nil leaves fans bitter"
could have a hash of "#opinion-soccer-matches-ending-in-nil-nil-leaves-fans-bitter"
"headline": "Eurovision song contest won by Ukraine"
could have a hash of "#event-eurovision-song-contest-won-by -ukraine"
To achieve that I'd have deterministic logic to look for "Report" and "Opinion" at the start of a headline for custom hashes, but default to "Event" (as now) for situations where I can't pick out either of those two alternates.