Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial_zoom: 0 is ignored #848

Open
dshapiro-whitecap opened this issue Feb 8, 2024 · 1 comment · May be fixed by #850
Open

initial_zoom: 0 is ignored #848

dshapiro-whitecap opened this issue Feb 8, 2024 · 1 comment · May be fixed by #850

Comments

@dshapiro-whitecap
Copy link

This issue is caused by this line:

TimelineJS3/src/js/timeline/Timeline.js

Line 437 in 6a78272

if (this.options.initial_zoom) {

The if condition inappropriately bypasses setting the initial zoom to index 0 due to the falsy nature of JavaScript and should, instead, be something like:

if (this.options.initial_zoom !== undefined && this.options.initial_zoom !== null)
@vivienzhou2014
Copy link

I am working on this.

@vivienzhou2014 vivienzhou2014 linked a pull request Mar 26, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed the line 437 that 0 is ignored when initial_zoom is defined as 0 vivienzhou2014/TimelineJS3
2 participants
@vivienzhou2014 @dshapiro-whitecap