Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Changing the name of a service removes it from Homekit #358

Closed
lougreenwood opened this issue Dec 30, 2020 · 7 comments
Closed

[Bug]: Changing the name of a service removes it from Homekit #358

lougreenwood opened this issue Dec 30, 2020 · 7 comments
Labels
enhancement 👍 New feature or request

Comments

@lougreenwood
Copy link

lougreenwood commented Dec 30, 2020

Describe the bug
When changing the name of a service (e.g a switch) in Node Red, the corresponding device in Homekit is destroyed and a new one is created.

This means that any automations in Homekit which make use of the device/service which just had it's name changed are now broken.

To Reproduce
Steps to reproduce the behaviour:

  1. Change the name of a device in Node Red which is associated with some automation in HomeKit
  2. See that on deploy, the automation is broken because the device is no longer associated with it

Expected behaviour
Changing the name of a service in Node Red should not cause side effects in Homekit

@lougreenwood lougreenwood added the bug 🐛 There is at least high chance that it is a bug! label Dec 30, 2020
@Shaquu
Copy link
Member

Shaquu commented Dec 30, 2020

According to HomeKit documentation by Apple Name should be persistent through the life of Accessory

image

@lougreenwood
Copy link
Author

Interesting, thanks.... however, somehow Philips Hue allows changing the accessory name and it doesn't break the automations. Any ideas?

Also, I wonder why the Home app allows changing the name, if it's intended to be immutable?

@Shaquu
Copy link
Member

Shaquu commented Dec 30, 2020

It's why I used Accessory word :)
We are working on it.

@lougreenwood
Copy link
Author

Thinking about this some more - I suppose this would allow Node Red/Homekit bridge portability between hardware installations?

For example, if I need to re-install node red & the HomeKit bridge on a new system and importing my existing config (something I'm considering, since I started my Node Red journey on a Raspberry Pi with Home Assistant, but I'm now realising I don't need Home Assistant, only Node Red). I presume that when this feature is implemented, then Homekit would in future recognise the devices as the same ones, and existing automations would continue to operate?

Is this a goal of the project?

@Shaquu
Copy link
Member

Shaquu commented Jan 2, 2021

@lougreenwood being native HomeKit as much as possible is our goal.
We are working to improve namings but it takes time as we need to be backward compatible.

@Shaquu
Copy link
Member

Shaquu commented Mar 27, 2021

  1. Name assigned in NodeRED cannot be changed - we are speaking about device identity
  2. For some Accessories/Services there is an option to change (separate) name displayed in Home.app. It should be possible in [FEATURE] Persist Bridge/Accessory/Service state #53

@Shaquu Shaquu added enhancement 👍 New feature or request and removed bug 🐛 There is at least high chance that it is a bug! labels Mar 27, 2021
@crxporter
Copy link
Member

Consolidating issues, please continue at #231 - it's pretty much the same thing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 👍 New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants