Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRL-817 permissions cache #673

Merged
merged 5 commits into from
Jul 9, 2024
Merged

NRL-817 permissions cache #673

merged 5 commits into from
Jul 9, 2024

Conversation

axelkrastek1-nhs
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2024

🚀 PR environment successfully deployed.
Commit Hash: c617976ce0e847effc4f06796e45ef5056aaa998
URL: https://nrl817-1663a7.api.record-locator.dev.national.nhs.uk/

@axelkrastek1-nhs axelkrastek1-nhs force-pushed the feature/axkr1-NRL-817-permissions-cache branch from c617976 to c6ea1f4 Compare July 3, 2024 16:02
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2024

🚀 PR environment successfully deployed.
Commit Hash: c6ea1f4677e509bced575af69bbf8728612b1727
URL: https://nrl817-1663a7.api.record-locator.dev.national.nhs.uk/

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 9, 2024

🚀 PR environment successfully deployed.
Commit Hash: b896b3d94bd3d349e7f08512a52e9a7a94321c50
URL: https://nrl817-1663a7.api.record-locator.dev.national.nhs.uk/

mattdean3-nhs
mattdean3-nhs approved these changes Jul 9, 2024
View reviewed changes
Copy link
Collaborator

@mattdean3-nhs mattdean3-nhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️ Tested both persistent-env and pr deploys, both worked and had the correct permissions when deployed. The build-artifacts zip file also no longer contains the permissions.

Nice work 👏

@axelkrastek1-nhs axelkrastek1-nhs merged commit 84c21ba into develop Jul 9, 2024
12 checks passed
@axelkrastek1-nhs axelkrastek1-nhs deleted the feature/axkr1-NRL-817-permissions-cache branch July 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdean3-nhs mattdean3-nhs mattdean3-nhs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axelkrastek1-nhs @mattdean3-nhs