[release/2023-08-14] Fix forward: remove tags from secuirty group ass…

…ociations
NHSDigital · Aug 15, 2023 · 2b88151 · 2b88151
1 parent 506fd6a
commit 2b88151
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 23 deletions.
diff --git a/terraform/account-wide-infrastructure/dev/rds-cluster-vpc.tf b/terraform/account-wide-infrastructure/dev/rds-cluster-vpc.tf
@@ -78,9 +78,4 @@ resource "aws_vpc_endpoint" "secretsmanager" {
 resource "aws_vpc_endpoint_security_group_association" "vpc_cluster_security_group_assoc" {
   vpc_endpoint_id   = aws_vpc_endpoint.secretsmanager.id
   security_group_id = aws_security_group.rds-cluster-sg-dev.id
-
-  tags = {
-    Name        = "${local.project}-dev-sg-association"
-    Environment = local.environment
-  }
 }
diff --git a/terraform/account-wide-infrastructure/prod/rds-cluster-vpc.tf b/terraform/account-wide-infrastructure/prod/rds-cluster-vpc.tf
@@ -78,9 +78,4 @@ resource "aws_vpc_endpoint" "secretsmanager" {
 resource "aws_vpc_endpoint_security_group_association" "vpc_cluster_security_group_assoc" {
   vpc_endpoint_id   = aws_vpc_endpoint.secretsmanager.id
   security_group_id = aws_security_group.rds-cluster-sg-prod.id
-
-  tags = {
-    Name        = "${local.project}-prod-sg-association"
-    Environment = local.environment
-  }
 }
diff --git a/terraform/account-wide-infrastructure/test/rds-cluster-vpc.tf b/terraform/account-wide-infrastructure/test/rds-cluster-vpc.tf
@@ -107,7 +107,7 @@ resource "aws_route_table_association" "private-int" {
 # VPC endpoints
 #------------------------------------------------------------------------------
 
-resource "aws_vpc_endpoint" "secretsmanager" {
+resource "aws_vpc_endpoint" "secretsmanager-ref" {
   vpc_id              = aws_vpc.rds-cluster-vpc-ref.id
   service_name        = "com.amazonaws.eu-west-2.secretsmanager"
   subnet_ids          = aws_db_subnet_group.rds-cluster-subnet-group-ref.subnet_ids
@@ -120,14 +120,9 @@ resource "aws_vpc_endpoint" "secretsmanager" {
   }
 }
 
-resource "aws_vpc_endpoint_security_group_association" "vpc_cluster_security_group_assoc" {
-  vpc_endpoint_id   = aws_vpc_endpoint.secretsmanager.id
+resource "aws_vpc_endpoint_security_group_association" "vpc_cluster_security_group_assoc-ref" {
+  vpc_endpoint_id   = aws_vpc_endpoint.secretsmanager-ref.id
   security_group_id = aws_security_group.rds-cluster-sg-ref.id
-
-  tags = {
-    Name        = "${local.project}-ref-sg-association"
-    Environment = local.environment
-  }
 }
 
 resource "aws_vpc_endpoint" "secretsmanager" {
@@ -146,9 +141,4 @@ resource "aws_vpc_endpoint" "secretsmanager" {
 resource "aws_vpc_endpoint_security_group_association" "vpc_cluster_security_group_assoc" {
   vpc_endpoint_id   = aws_vpc_endpoint.secretsmanager.id
   security_group_id = aws_security_group.rds-cluster-sg-int.id
-
-  tags = {
-    Name        = "${local.project}-int-sg-association"
-    Environment = local.environment
-  }
 }