-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper handling of OfferCreate type of transactions #4
Comments
This is because the exchange in question consumed 2 offers. You can pass PS. I respect your courage to use this library in alpha without any documentation whatsoever 😄 |
Do you mean like using your library? I've started working on a ready made project and there happened an issue with improper calculation of exchange rates for OfferCreate type of transactions. Wondering how have you figured out to calculate a transaction balance by subtracting (previousTakerPays.value - finalTakerPays.value) as this is not in documentation? |
|
A transaction of this kind when doing a token-token exchange will return 2 separate transactions with parseExchanges() with absolutely wrong exchange rates.
From what I have discovered, there is only documentation for a transaction metadata at https://xrpl.org/transaction-metadata.html
but nothing really about what is inside of PreviousFields and FinalFields.
That's why I'm wondering where the logic from parseExchanges() comes from?
Thanks
PS. I have found an abandoned project at https://www.npmjs.com/package/ripple-lib-transactionparser and also ripple-lib which are closed in flavor of the official https://github.com/XRPLF/xrpl.js
But can't really find how can you parse a transaction with it.
The text was updated successfully, but these errors were encountered: