ogg chaining support now in flac! ＼(＾O＾)／

[whatamesss]

Bug report

Describe the bug

ogg chain playback has long been broken in flac

Expected Behavior

streams continue to play as song changes occur

Actual Behavior

player hangs or stops at song change/serial number update

Version

mpd-git
flac-git

Configuration

this patch enables the feature:

diff --git a/src/libFLAC/ogg_decoder_aspect.c b/src/libFLAC/ogg_decoder_aspect.c
index 2cd06278..bb04a9c4 100644
--- a/src/libFLAC/ogg_decoder_aspect.c
+++ b/src/libFLAC/ogg_decoder_aspect.c
@@ -83,7 +83,7 @@ void FLAC__ogg_decoder_aspect_set_serial_number(FLAC__OggDecoderAspect *aspect,
void FLAC__ogg_decoder_aspect_set_defaults(FLAC__OggDecoderAspect *aspect)
{
aspect->use_first_serial_number = true;

• aspect->decode_chained_stream = false;

• aspect->decode_chained_stream = true;
  }

void FLAC__ogg_decoder_aspect_flush(FLAC__OggDecoderAspect *aspect)

Log

please update mpd to make use of new flac git master (abi changes?)

[whatamesss]

xiph/flac#735 (comment)

[jcorporation]

Why do you not provide a pull request? Should this be enabled only for specific flac versions?

[MaxKellermann]

The patch is not a MPD patch because the affected source file does not exist in MPD. I don't know what kind of patch this is, but I guess this feature request is bogus.

[whatamesss]

this is not an mpd patch it actually patches flac source code to enable the chaining feature...please hold tight. i'm trying to figure this out.
this fixes an issue reported to mpd many times...the fix is in libflac, but the flac author said clients will need to make changes too...i'm trying to gather more info

[whatamesss]

Why do you not provide a pull request? Should this be enabled only for specific flac versions?

until the flac makes a release, this would only be usable in the git master....just hoping you guys can prepare mpd and make it use the feature. for now, it will have to be enabled by the distro or user by patching flac