Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pull to refresh behavior #270

Open
webframp opened this issue May 20, 2020 · 2 comments
Open

Implement pull to refresh behavior #270

webframp opened this issue May 20, 2020 · 2 comments
Labels
feature request Flag an issue as a request to add new features

Comments

@webframp
Copy link
Member

This is a pretty standard behavior on iOS for forcing a refresh action. We
currently only have the sync button on the main outlines view, but could make
pull to refresh work from any screen for consistency.

@webframp webframp added the feature request Flag an issue as a request to add new features label May 20, 2020
@dive
Copy link
Member

dive commented May 20, 2020

Just a note.

It is quite easy to implement but the problem is that we block UI during the refresh for now. It was done to protect the database from any changes during the synchronisation process.

So, we can implement a transparent synchronisation for sure and do not block UI at all (we have to support merging, etc., if a user changes something during the synchronisation then we have to merge these changes back when synchronisation is completed). But I think it will take some time and will introduce some breaking changes. Anyway, we have to take the current implementation into account.

@webframp
Copy link
Member Author

Great details @dive

That’s for sure why it doesn’t currently exist, I wanted to have an issue for it since I’m trying to make it easier for contributors to add their thoughts or see what features have been discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Flag an issue as a request to add new features
Projects
None yet
Development

No branches or pull requests

2 participants