Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the gpu() functions if not needed #1

Open
ViralBShah opened this issue May 26, 2018 · 6 comments
Open

Remove the gpu() functions if not needed #1

ViralBShah opened this issue May 26, 2018 · 6 comments

Comments

@ViralBShah
Copy link

IIRC, the gpu() functions are not needed any more and to run on GPUs, one only needs CuArrays. If so, can the notebooks be updated accordingly?

Also, should we register as a Julia package?

@MikeInnes
Copy link
Owner

You still need the call to gpu to actually transfer things there (if applicable).

Is it helpful for this to be a package? The main difference seems to be using add rather than git clone, but then you have to know how to find things in your package folder anyway.

@ViralBShah
Copy link
Author

Sorry - I just meant those gpu functions on the top of the notebook.

@ViralBShah
Copy link
Author

The other benefits of a package could probably be things like CI and an easy way to install, but not the most pressing point for now.

@MikeInnes
Copy link
Owner

Ah, got it – yeah these notebooks definitely need a refresh then.

I don't know if there's a canonical way to do CI for notebooks, but we could probably get something together with nbinclude or similar.

@tberky
Copy link

tberky commented Aug 9, 2020

Is there any chance to find out in what versions were the Flux GitHub stuff written? Because most of it doesnt work for me even when i read readme files and just copy paste it...
@MikeInnes

@niczky12
Copy link

Maybe PkgUtils.jl could be used here? Just saw this video the other day from JuliaCon: https://www.youtube.com/watch?v=LYVdRTuxS_c&t=1s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants