Skip to content
This repository has been archived by the owner on Oct 14, 2020. It is now read-only.

Suggest not to set appsDirectory=apps when installing app in boost. #388

Open
patricktiu opened this issue Sep 16, 2019 · 5 comments
Open

Comments

@patricktiu
Copy link
Member

Since the LMP has a "smart" default for the appsDirectory, you might not need to set it yourself.

See the appsDirectory smart default documentation:
https://github.com/OpenLiberty/ci.maven/blob/master/docs/deploy.md

boost.runtimes.openliberty.LibertyRuntime:

    /**
     * Invoke the liberty-maven-plugin to run the install-app goal.
     */
    private void installApp(String installAppPackagesVal) throws MojoExecutionException {

        Element deployPackages = element(name("deployPackages"), installAppPackagesVal);
        Element serverNameElement = element(name("serverName"), serverName);

        Xpp3Dom configuration = configuration(deployPackages, serverNameElement, getRuntimeArtifactElement());
        configuration.addChild(element(name("appsDirectory"), "apps").toDom());

        executeMojo(getPlugin(), goal("deploy"), configuration, env);
    }
@cherylking
Copy link
Member

There are other defaults specified as well that do not need to be...like this one:

element(name("outputDirectory"), "target/liberty-alt-output-dir"),

@scottkurz
Copy link
Contributor

@cherylking We just put that back in last week since @chyt said it wasn't actually defaulted. Anyway, will save that for later since I have the Travis running in #389.

@scottkurz
Copy link
Contributor

OK, I see the change. Will delete outputDirectory too..thx @cherylking

@patricktiu
Copy link
Member Author

I can't remember but there is a reason to use a non-default outputDirectory for package goal.

Would that be running package goal with a running server?

@patricktiu
Copy link
Member Author

I think @cherylking is right, the default outputDirect for package goal is target/liberty-alt-output-dir now in 3.0.1 and it is different from the one in run goal. So you don't need it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants