Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Investigation]: Further EIP-2612 support for Redesign Confirmations #27269

Open
9 tasks
digiwand opened this issue Sep 19, 2024 · 0 comments
Open
9 tasks

[Investigation]: Further EIP-2612 support for Redesign Confirmations #27269

digiwand opened this issue Sep 19, 2024 · 0 comments
Labels
team-confirmations Push issues to confirmations team

Comments

@digiwand
Copy link
Contributor

What is this about?

We need to investigate the following EIP-2612 support further and potentially address:

  • Backwards Compatibility

    • Instead of value, can support allowed (values are handled differently. Please read doc to add support)
    • Handle expiry condition

      There is also an implementation in the token Stake (Ethereum address 0x0Ae055097C6d159879521C384F1D2123D1f195e6) with the same ABI as dai but with different semantics: it lets users issue “expiring approvals”, that only allow transferFrom to occur while expiry >= block.timestamp.

  • Security Considerations

    • Check

      it is important to ensure owner != address(0) to avoid permit from creating an approval to spend “zombie funds” belong to the zero address.

Scenario

No response

Design

No response

Technical Details

No response

Threat Modeling Framework

No response

Acceptance Criteria

No response

Stakeholder review needed before the work gets merged

  • Engineering (needed in most cases)
  • Design
  • Product
  • QA (automation tests are required to pass before merging PRs but not all changes are covered by automation tests - please review if QA is needed beyond automation tests)
  • Security
  • Legal
  • Marketing
  • Management (please specify)
  • Other (please specify)

References

No response

@digiwand digiwand added the team-confirmations Push issues to confirmations team label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-confirmations Push issues to confirmations team
Projects
None yet
Development

No branches or pull requests

1 participant