Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified login #1481

Merged
merged 89 commits into from
Sep 23, 2024
Merged

Unified login #1481

merged 89 commits into from
Sep 23, 2024

Conversation

Voltmod
Copy link
Collaborator

@Voltmod Voltmod commented Aug 12, 2024

Changes in this PR:

  • Provide unified login interface with MetaMask login button in the main header
  • Adding a feature flag to hide this button mm-unified-login

How to test:

Screenshot 2024-09-19 at 17 36 24
  • You should see a modal like this
Screenshot 2024-09-18 at 18 09 37
  • If your wallet is linked with an Infura account, nothing to do, you will connect instantaneously

  • If your wallet is not linked you will be redirected to the dashboard to enter and link your Infura account with email/password

Screenshot 2024-09-20 at 12 44 40
  • If your wallet is linked with multiple Infura account you will be redirected to the dashboard to select which account you want to use
Screenshot 2024-09-20 at 12 57 17
  • Then you should be redirected to the documentation and see your Infura projects API Keys
Screenshot 2024-09-20 at 12 52 10

Links:

JIRA Issue

Vlad Lo. and others added 30 commits July 9, 2024 11:35
ACT-1388: Component: Button
ACT-1387: Component: Tabs
* ACT-1393 Component: Typography
* ACT-1386 Component: Accordion
# Conflicts:
#	docusaurus.config.js
#	tsconfig.json
* ACT-1394 Component: Alert + Prettier whole project
* feat(faucet): act-1391 - added badge component

* feat(faucet): act-1391 - fix for css vars
ACT-1473 Assemble faucet page (#1448)
# Conflicts:
#	src/components/ParserOpenRPC/AuthBox/index.tsx
#	src/components/ParserOpenRPC/index.tsx
#	src/theme/Layout/index.tsx
#	src/theme/Root.tsx
Faucet maintenance mode (#1475)
…mm-docs

# Conflicts:
#	package.json
#	src/components/CodeTerminal/TerminalViewBox.jsx
#	src/components/ParserOpenRPC/InteractiveBox/index.tsx
#	src/components/ParserOpenRPC/index.tsx
#	src/hooks/useUser.js
#	src/theme/Layout/index.tsx
#	src/theme/Root.tsx
#	tsconfig.json
#	yarn.lock
cedricmagne
cedricmagne previously approved these changes Sep 19, 2024
cedricmagne
cedricmagne previously approved these changes Sep 20, 2024
Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-09-20 at 9 27 42 AM

The color of this text should be updated for light mode.

Also, for some reason my Infura credentials don't work with the redirected login page, however, the same exact credentials work on https://app.infura.io/ (I've double checked this on the latest build)
Screenshot 2024-09-20 at 9 30 11 AM

@cedricmagne
Copy link
Collaborator

cedricmagne commented Sep 20, 2024

Details

Credentials for preview app env can be different than PROD env.
If you don't have an account on our preview env https://app-git-act-1382-siwsrp-full-flow-infura-web.vercel.app/login please create one first. Then go back to MetaMask Doc

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cedricmagne cedricmagne merged commit 4db208f into main Sep 23, 2024
7 of 9 checks passed
@cedricmagne cedricmagne deleted the unified-login branch September 23, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants