Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ru-RU locale #510

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gaussandhisgun
Copy link

@gaussandhisgun gaussandhisgun commented Sep 7, 2021

Description

PR that adds a Russian localisation to Assistant app itself.

Resolved / Related Issues

Issues resolved or addressed by this PR.

Type of Change

  • [ x ] Localization

P.S. I have no ways to build the assistant on my Windows laptop, tho I don't think a locale would break something important, huh.

@Melvin-Abraham
Copy link
Owner

Although, the official Google Assistant Client does support Russian right away but the gRPC client does have some limitations in such matters. Although, it's not possible to have a direct option for Russian (at least right now), you can still talk to the Assistant in Russian and it will continue the conversation without any hassle. There are already plans to work on multiple languages after the next release but those will only be targeted towards the interface language as for the conversation language it's not officially supported in gRPC.

I don't think a locale would break something important, huh.

Actually, the assistant would fail to start as it's part of the initialization process. Reference: #70 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants