Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added very faint shadow behind the window to help is stand out a bit from the background #37

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Epacik
Copy link

@Epacik Epacik commented Nov 13, 2020

When using GA on top of a window with the same or similar background color it's sometimes quite hard to differentiate between GA and the window behind it.
I've added a faint shadow which should help it stand out a bit

…from the background

When using GA on top of a window with the same or similar backfround color it's sometimes quite hard to differentiate  between GA and the window behind it.
I've added a faint shadow which should help it stand out a bit
@Melvin-Abraham
Copy link
Owner

@Epacik Appreciate the contribution. Although, I am a bit reluctant to merge this PR due to the following concerns:

  • Some contents seem to overflow past the defined boundary causing scrollbars to show up
  • Creates padding around window which would cause confusion when resizing the window
  • The effect might be too subtle to notice
  • Causes slight change in the positioning of title bar [minor]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants