Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix images src #51

Open
MattCrl opened this issue Oct 2, 2018 · 5 comments
Open

Fix images src #51

MattCrl opened this issue Oct 2, 2018 · 5 comments
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@MattCrl
Copy link
Owner

MattCrl commented Oct 2, 2018

Sometimes, contributors does a mistake with the src link of their picture. So no picture is loaded. I see a lot of "image.JPG" instead of just "image.jpg" If you find one that i missed when you work on this project, please just correct it and i'll merge your PR ! Thanks
@MattCrl MattCrl added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 2, 2018
@Vishal1541
Copy link
Contributor

@MattCrl I would like to work on this.

@Yusadolat Yusadolat mentioned this issue Oct 2, 2018
Closed
@Yusadolat
Copy link

I just did that please check 😆

jopime added a commit to jopime/Contributors-portraits that referenced this issue Oct 2, 2018
@jopime
Fix images src MattCrl#51
3209f74 
Fix images src MattCrl#51
@jopime jopime mentioned this issue Oct 2, 2018
Merged
jopime added a commit to jopime/Contributors-portraits that referenced this issue Oct 2, 2018
@jopime
Merge pull request #2 from jopime/jopime-patch-2
e61a17f 
Fix images src MattCrl#51
@logichub logichub mentioned this issue Oct 2, 2018
Merged
@MattCrl MattCrl removed the help wanted Extra attention is needed label Oct 4, 2018
@Cherrytone
Copy link
Contributor

I just did a pull request for fixing 2 images there were not displaying.

@TobiDueces TobiDueces mentioned this issue Oct 29, 2018
Open
@Swayamsvk
Copy link

I think some images are not present in the images folder thats why they are not loading.

conejodan added a commit to conejodan/Contributors-portraits that referenced this issue Oct 9, 2019
@conejodan
Fix images src MattCrl#51
00dadba
@yas-sisodia
Copy link

@MattCrl Please assign this issue to me. I can do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@Yusadolat @Vishal1541 @MattCrl @Cherrytone @Swayamsvk @yas-sisodia