Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] MARLINUI doesn't change language with MKS_TS35_V2_0 #27453

Closed
1 task done
anomalchik opened this issue Oct 3, 2024 · 2 comments
Closed
1 task done

[BUG] MARLINUI doesn't change language with MKS_TS35_V2_0 #27453

anomalchik opened this issue Oct 3, 2024 · 2 comments

Comments

@anomalchik
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

UI language does not change

Bug Timeline

No response

Expected behavior

No response

Actual behavior

Running with English language.

Steps to Reproduce

  1. #define MKS_TS35_V2_0
  2. #define TFT_COLOR_UI
  3. #define DISPLAY_CHARSET_HD44780 CYRILLIC
  4. #define LCD_LANGUAGE ru
  5. uncomment CONFIG_EXPORT in Configuration_adv
  6. compile firmware
  7. check exported configuration and you will see that the DISPLAY_CHARSET_HD44780 and LCD_LANGUAGE parameters have not been exported

Version of Marlin Firmware

bugfix-2.1.x (2024-09-29)

Printer model

Custom

Electronics

BOARD_MKS_ROBIN_NANO_V3

LCD/Controller

MKS_TS35_V2_0

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

config.zip

@ellensp
Copy link
Contributor

ellensp commented Oct 3, 2024

HD44780 is for character LCD displays so #define DISPLAY_CHARSET_HD44780 CYRILLIC is not used.

but your correct #define LCD_LANGUAGE ru is not working.

Marlin has this line which incorrectly removes LCD_LANGUAGE

#if NONE(HAS_MARLINUI_U8GLIB, HAS_TFT_LVGL_UI, DGUS_LCD_UI_E3S1PRO)
  #undef LCD_LANGUAGE
#endif

update Marlin/src/inc/Conditionals-2-LCD.h with this code seems like a good fix.

#if NONE(HAS_MARLINUI_U8GLIB, HAS_TFT_LVGL_UI, TFT_COLOR_UI, DGUS_LCD_UI_E3S1PRO)
  #undef LCD_LANGUAGE
#endif

@ellensp
Copy link
Contributor

ellensp commented Oct 3, 2024

I have created a PR to fix this going forward.

@ellensp ellensp closed this as completed Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants