Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Compilation error with DWIN_CREALITY_LCD_JYERSUI (error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; ) #26188

Closed
1 task done
stoubian opened this issue Aug 19, 2023 · 5 comments

Comments

@stoubian
Copy link

Did you test the latest bugfix-2.1.x code?

Yes, and the problem still exists.

Bug Description

With DWIN_CREALITY_LCD_JYERSUI defined,
When compiling in VSCode with PIO,
The compiler throws the error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; did you mean 'MSG_MMU2_MENU'?

The fix proposed on reddit by nanmetal worked fine after test.
link here

I make a PR asap

Bug Timeline

new

Expected behavior

I expect the code compiles without error.

Actual behavior

The compiler throws the error: 'MSG_MAIN_MENU' is not a member of 'Language_en'; did you mean 'MSG_MMU2_MENU'?

Steps to Reproduce

  1. take the example default configuration.h file or any configuration.h file
  2. uncomment DWIN_CREALITY_LCD_JYERSUI
  3. compile
  4. error

Version of Marlin Firmware

2.1.2.1

Printer model

Creality Ender-3 V2

Electronics

Stock electronics

Add-ons

No response

Bed Leveling

UBL Bilinear mesh

Your Slicer

Prusa Slicer

Host Software

SD Card (headless)

Don't forget to include

  • A ZIP file containing your Configuration.h and Configuration_adv.h.

Additional information & file uploads

No response

@thisiskeithb
Copy link
Member

Are you using a fork? MSG_MAIN_MENU is in the language file(s):

LSTR MSG_MAIN_MENU = _UxGT("Main Menu");

Using the stock Ender-3 V2 Creality UI config and enabling DWIN_CREALITY_LCD_JYERSUI instead of DWIN_CREALITY_LCD works fine.

@stoubian
Copy link
Author

stoubian commented Aug 19, 2023

I am using the code revision at tag 2.1.2.1 and the error is in that version but I see it has been fixed by this commit on the branch bugfix-2.1.x : link to the commit

@thisiskeithb
Copy link
Member

I am using the code revision at tag 2.1.2.1 and the error is in that version but I see it has been fixed by this commit on the branch bugfix-2.1.x : link to the commit

That's why we ask if you've tested the latest bugfix-2.1.x before opening up new issues:

Did you test the latest bugfix-2.1.x code?
Yes, and the problem still exists.

@stoubian
Copy link
Author

My bad, I don't know why I was thinking that tag 2.1.2.1 was in advance of branch bugfix-2.1.x but this is clearly not the case 😅
Thanks for your fast answer (and for maintianing the project)!

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants