Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Add an extra argument to M600, to show to which filament the user has to change. #26155

Closed
plampix opened this issue Aug 5, 2023 · 9 comments
Labels
T: Feature Request Features requested by users.

Comments

@plampix
Copy link
Contributor

plampix commented Aug 5, 2023

Is your feature request related to a problem? Please describe.

When doing rather simple multi-colour prints with just one nozzle, no mmu, and you use more than 2 colours, it can be hard to tell to which filament you need to change. Just adding a number to the message on screen could help a lot.

Describe the feature you want

An extra argument to M600 that contains text that can be displayed in the 'Insert filament and press button' message, for example replace it with 'Insert filament 3 and press button'.

@plampix plampix added the T: Feature Request Features requested by users. label Aug 5, 2023
@DerAndere1
Copy link
Contributor

DerAndere1 commented Aug 6, 2023

This would mean that we introduce a redundant functionality. For the purpose of color change, the tool change command (T) is well established. With your proposal, slicer, firmware and host software have to track both, tool number and filament number. I think it is more consistent to just use the T command and implement a manual toolchange procedure that in your case only includes a filament change (see pull request #23575). Then, each tool number represents a different filament.

@plampix
Copy link
Contributor Author

plampix commented Aug 6, 2023

Yeah, that should certainly work, and be less redundant. I'll keep watching that PR, and close this one.

@plampix plampix closed this as completed Aug 6, 2023
@DerAndere1
Copy link
Contributor

for your specific usecase, after merging PR 23575, you will have to add this line of code:
M600();
somewhere here https://github.com/MarlinFirmware/Marlin/pull/23575/files#diff-9876938bb66214705f89adf5ab50fd49d5504d318662b5c996ac0eba2c434587L646

@plampix
Copy link
Contributor Author

plampix commented Aug 7, 2023

Either that, or add M702/M701. I'll figure it out when MANUAL_SWITCHING_TOOLHEAD becomes available.

@DerAndere1
Copy link
Contributor

DerAndere1 commented Aug 7, 2023

Probably the merge of that PR into official bugfix-2.1.x won't happen anytime soon. You can checkout the pull request yourself using git:

lets say you have forked Marlin and https://github.com/MarlinFirmware/Marlin is the upstream remote repository.

Then you can fetch an upstream PR like this:

git fetch upstream pull/$ID/head:$BRANCHNAME

where $ID is the pull request id and $BRANCHNAME is the name of the new branch that you want to create (replace both placeholders!). Once you have created the branch, then simply checkout your newly created branch:

git checkout $BRANCHNAME

(modified from https://stackoverflow.com/questions/27567846/how-can-i-check-out-a-github-pull-request-with-git)

@EvilGremlin
Copy link
Contributor

On-screen status message like "Insert green PETG" will be very helpful, but it can be done in two ways.
First is to include status message on filchange screen, then use M117 in color/tool change gcode.
Second is to add separate string to M600 and filchange screens.
In any case, slicers must support inserting next filament name as variable, which i don't think any do.

@plampix
Copy link
Contributor Author

plampix commented Aug 8, 2023

PrusaSlicer can do this, and I already use that with M117 and M118, but the message disappears when the display shows the change filament status screen.

But there's no rush, I can always check my Octoprint to check which filament I need. Would be nice to also show it on the printer though, for people that print from SD.

@plampix
Copy link
Contributor Author

plampix commented Aug 8, 2023

Hmm, I could just show it directly after changing filament, instead of just before changing. Then I just prepare for the next change, and do whatever was prepared when M600 runs. I'm stupid :)

@github-actions
Copy link

github-actions bot commented Oct 7, 2023

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: Feature Request Features requested by users.
Projects
None yet
Development

No branches or pull requests

3 participants