Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split each feature into separate component #15

Open
MarcusOtter opened this issue Oct 19, 2022 · 0 comments
Open

Split each feature into separate component #15

MarcusOtter opened this issue Oct 19, 2022 · 0 comments

Comments

@MarcusOtter
Copy link
Owner

I think it would be neat to split each of these features into their own component

image

Just spitballing here, but maybe some props for them could be:

  • heading (string)
  • body (string)
  • command heading (string)
  • command icon url (string)
  • commands (string array)
  • is flipped (bool)
  • background image url (string)
  • showcase media (video/image url string?)

However, it will maybe be easier to implement & use if we use named slots to pass down some of these things instead of the url (send the whole image/component instead). Otherwise we'd have to deal with images and videos separately depending on URL somehow I feel like. Don't know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant