Undocumented detail in the setup of settings.yml

[europ]

NoMethodError: undefined method 'each' for nil:NilClass

at

miq_bot/app/workers/commit_monitor_handlers/commit_range/path_based_labeler.rb

Line 21 in ca62968

label_rules.each do |rule|

2018-02-21T07:42:11.405Z 24598 TID-gnaf0hvnk WARN: NoMethodError: undefined method `each' for nil:NilClass
2018-02-21T07:42:11.405Z 24598 TID-gnaf0hvnk WARN: /root/miq_bot/app/workers/commit_monitor_handlers/commit_range/path_based_labeler.rb:21:in `process_branch'
/root/miq_bot/app/workers/commit_monitor_handlers/commit_range/path_based_labeler.rb:14:in `perform'
/root/.rbenv/versions/2.3.6/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:152:in `execute_job'
...

due to uninitialized variable

miq_bot/config/settings.yml

Line 28 in ca62968

rules: {}

Example how to solve:

...

# Worker settings
diff_content_checker:
  offenses: {}
merge_target_titler:
  included_repos: []
path_based_labeler:
  rules:
    organization/repository: []
travis_build_killer:
  included_repos: []

[Fryguy]

strange...how is this working in production? We definitely don't have rules for every repo, and according to

miq_bot/app/workers/commit_monitor_handlers/commit_range/path_based_labeler.rb

Line 31 in 8bbabd9

Settings.path_based_labeler.rules[fq_repo_name]

a missing repo will return nil.

[juliancheal]

a missing repo will return nil.

Yeah but returning nil, means https://github.com/ManageIQ/miq_bot/blob/master/app/workers/commit_monitor_handlers/commit_range/path_based_labeler.rb#L21 blows up.

[Fryguy]

Right, so I can't understand how's it's working in production presently. It should be blowing up constantly.

[europ]

What are the rules in production?

path_based_labeler:
  rules:

I always faced this NoMethodError until I added some empty fake org/repo into rules to make them non-empty.

[Fryguy]

yeah, it turns out it's a coincidence that it's working in production...the settings are:

path_based_labeler:
  included_repos:
  - ManageIQ/manageiq
  - ManageIQ/manageiq-ui-classic
  rules:
    ManageIQ/manageiq:
    - ...
    ManageIQ/manageiq-ui-classic:
    - ...

So, we happen to set the included_repos as well as the rules which ensures only those valid repos are even called.

[miq-bot]

This issue has been automatically marked as stale because it has not been updated for at least 3 months.

If you can still reproduce this issue on the current release or on master, please reply with all of the information you have about it in order to keep the issue open.

Thank you for all your contributions! More information about the ManageIQ triage process can be found in the traige process documentation.