Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disconnect apparently not killing service permanently #51

Open
hank opened this issue Feb 3, 2014 · 4 comments
Open

Disconnect apparently not killing service permanently #51

hank opened this issue Feb 3, 2014 · 4 comments
Labels
bug
Milestone
3.30.5

Comments

@hank
Copy link
Member

hank commented Feb 3, 2014

Something is apparently still turning the service on after Disconnect:

It happened each time after ~20 minutes I think. The notification came back and it started to connect to more and more peers. I had to "disconnect" the app over and over again (I think in total 5 times).

https://litecointalk.org/index.php?topic=12196.msg114690#msg114690
@santa4nt
Copy link

santa4nt commented Feb 3, 2014

This is because of commit d3a4cf0, which merges an upstream commit 9dd696. Particularly, line 737 in BlockchainServiceImpl.java, function onDestroy() that added:

WalletApplication.scheduleStartBlockchainService(this);

I assumed this was added to force a service restart in event of anomalous service interruption (like low memory, etc)?

santa4nt referenced this issue in bitcoin-wallet/bitcoin-wallet Feb 3, 2014
@schildbach
Fix frequency backoff of sync operations
9dd6965
@santa4nt santa4nt mentioned this issue Feb 3, 2014
Merged
@hank
Copy link
Member Author

hank commented Feb 4, 2014

Fantastic. This will be included in the next release, and we'll see if it helps the users who were having issues.

santa4nt referenced this issue Feb 5, 2014
@hank
Reverting to old blockchain code
1197a67 
The notification code requiring the new support library broke
the app in production.  Going back to the way it was, but keeping
all the other changes to the app.  Production ready signed APK
tested on one of my devices.
@hank
Copy link
Member Author

hank commented Feb 5, 2014

Need to remove WalletApplication.scheduleStartBlockchainService(this); from the shutdowns.

@santa4nt santa4nt mentioned this issue Feb 5, 2014
Open
@hank
Copy link
Member Author

hank commented May 7, 2014

I believe this is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
3.30.5
Development

No branches or pull requests
2 participants
@hank @santa4nt