Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main #435

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Main #435

wants to merge 1 commit into from

Conversation

ketan3108
Copy link

Changed comment from German to English in following three files :

  1. core/src/main/java/de/muenchen/allg/itd51/wollmux/db/AttachDatasource.java
  2. core/src/main/java/de/muenchen/allg/itd51/wollmux/db/ColumnNotFoundException.java
  3. core/src/main/java/de/muenchen/allg/itd51/wollmux/db/ColumnTransformer.java

@@ -42,23 +42,23 @@
<attribute name="m2e-apt" value="true"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes in this file.

public AttachDatasource(Map<String, Datasource> nameToDatasource, ConfigThingy sourceDesc,
URL context)

public AttachDatasource(Map<String, Datasource> nameToDatasource, ConfigThingy sourceDesc, URL context)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are code changes included here?

@@ -190,9 +193,10 @@ public List<String> getSchema()

/*
* (non-Javadoc)
*
*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no whitespace changes

@@ -37,23 +37,23 @@
<attribute name="m2e-apt" value="true"/>
</attributes>
</classpathentry>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert changes here

public QueryResults transform(QueryResults qres)
{
return new TranslatedQueryResults(qres);
}

/**
* Stellt die Spalten eines Datasets als Values zur Verfügung.
* Provides the columns of a dataset as values.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Values in uppercase (Interface name)

@@ -23,11 +23,6 @@
<attribute name="maven.pomderived" value="true"/>
</attributes>
</classpathentry>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes here please

@thorstenb
Copy link
Contributor

Quick ping, still working on this PR? If a bit of support would be useful, to untangle the unrelated changes, please let us know!

@thorstenb thorstenb force-pushed the main branch 2 times, most recently from 5632e2d to c721649 Compare July 31, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants